chore: move knex-specific loader logic out of EntityDataManager#408
Conversation
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
wschurman
force-pushed
the
wschurman/01-30-chore_move_knex-specific_loader_logic_out_of_entitydatamanager
branch
3 times, most recently
from
ee57e84 to
0be9f1d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## wschurman/01-30-feat_move_knex-specific_loader_methods_to_knexloader #408 +/- ##
========================================================================================================
Coverage ? 100.00%
========================================================================================================
Files ? 97
Lines ? 13171
Branches ? 665
========================================================================================================
Hits ? 13171
Misses ? 0
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Jan 31, 2026
Open
wschurman
force-pushed
the
wschurman/01-30-chore_move_knex-specific_loader_logic_out_of_entitydatamanager
branch
from
0be9f1d to
733b363
Compare
wschurman
force-pushed
the
wschurman/01-30-feat_move_knex-specific_loader_methods_to_knexloader
branch
from
fd886c7 to
a0423c5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Part 2 of #407.
How
Refactor methods into a separate class for future move out of main package.
Test Plan
Full test coverage.