chore(runtime): Migrate from activateKeepAwake to activateKeepAwakeAsync#603
Open
robwalkerco wants to merge 1 commit intoexpo:mainfrom
Open
chore(runtime): Migrate from activateKeepAwake to activateKeepAwakeAsync#603robwalkerco wants to merge 1 commit intoexpo:mainfrom
robwalkerco wants to merge 1 commit intoexpo:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
When playing with some snacks, I was spotting this getting logged to the console -
Chrome:activateKeepAwakeis deprecated. UseactivateKeepAwakeAsyncinstead.so I thought it would be helpful if I open a PR to resolve the deprecation notice,Replication steps:
Kapture.2024-08-23.at.14.53.51.mp4
How
This was a simple search and replace PR :)
Test Plan
I was not able to fully test this, as I not able to get the local web-player running locally within the Expo Snack website :(
I tried running
runtimeandruntime-shellwith port19006and although they were running locally, noting was being rendered, and I was getting 404 errors forhttp://snack.expo.test/index.bundle?platform=web&dev=true&hot=false&lazy=true&transform.engine=hermes&transform.baseUrl=%2Fv2%2F51&transform.routerRoot=app