Do not override FS config if no allowed paths are provided #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thank you @mymmrac! Will have one more person take a look at this for some additional guidance, but I think this looks good. |
mhmd-azeez
approved these changes
Jan 14, 2025
Contributor
mhmd-azeez
left a comment
mhmd-azeez
left a comment
There was a problem hiding this comment.
lgtm, thanks for the PR!
Contributor
|
note to self: will need to do something similar in the chicory-sdk! |
Contributor
Author
|
@mhmd-azeez @evacchi please merge this PR if everything is ok, since I don't have write permissions I can't merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows users to use FS config from
ModuleConfig(FS is overridden only if Manifest specifiesAllowedPaths)