Conversation
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
| export function registerHuaweiListeners() { | ||
| if (!WearEngine || !WearEngine.addListener) { | ||
| return; | ||
| } | ||
|
|
||
| WearEngine.addListener('message', (payload: Payload) => { | ||
| DeviceEventEmitter.emit('message', payload); | ||
| }); | ||
|
|
||
| WearEngine.addListener('fileTransfer', (event: any) => { |
There was a problem hiding this comment.
[P1] Huawei events never reach watchEvents API
registerHuaweiListeners forwards Wear Engine callbacks to DeviceEventEmitter, but the library’s public watchEvents helper listens via a NativeEventEmitter attached to the Android module. Because nothing subscribes to DeviceEventEmitter for 'message', consumers calling watchEvents.on('message') will miss Huawei messages even after registering these listeners, so the new connector doesn’t actually integrate with the existing event API.
Useful? React with 👍 / 👎.
Summary
react-native-wear-enginedependency and HMS build configurationTesting
yarn lint(fails: ESLint couldn't find the plugin "eslint-plugin-ft-flow")yarn test(fails: Cannot find module '@react-native/babel-preset')https://chatgpt.com/codex/tasks/task_e_68b70276d4408320968e1467a5a91c39