Skip to content

sb: rb: Modified power capping and add MPS vr test mode functions#2661

Closed
khoung76642 wants to merge 50 commits intofacebook:mainfrom
khoung76642:upcode_sb-rb_20260301
Closed

sb: rb: Modified power capping and add MPS vr test mode functions#2661
khoung76642 wants to merge 50 commits intofacebook:mainfrom
khoung76642:upcode_sb-rb_20260301

Conversation

@khoung76642
Copy link
Contributor

Summary:

  • change the bootstrap default value (T17CISB-990)
  • modified HAMSA_AVDD_PCIE slow ocp to 50A in test mode
  • modified medha0/1 ocp from 1450 to 1430 in both of test mode and normal mode
  • add setting Vout to default when exit test mode
  • fix the sensor name rule
  • add dynamic change polling rate
  • apply upstream patch 0032-driver-pwm-add-output-open-drain-support.patch
  • configure pwm1 and pwm6 devicetree nodes to enable drive-open-drain (change output from push-pull to open-drain)
  • remove perm function from Vout Voltage set
  • add debug vr voltage for power capping
  • add ADC info in test info
  • fix typo for shell
  • add adc vendor test
  • fix power capping get vr power value format
  • fix i2c get vr power value format
  • add i2c target 0x95 0x96 0x97
  • add rns vr dma
  • add rns vr uvp/ovp enable
  • add vr get page
  • check vr test mode in bic start
  • add vr test mode dma shell commands
  • add vr test mode pmbus shell commands
  • disable unused function
  • remove set is_default from Vout set function
  • add vr rns access check dc status
  • modify vr test mode thread stack size
  • enable float point print
  • add shell pldm to bmc cmd
  • fix force_read_asic_version (T17CISB-1008)
  • set MUX to ASIC after done
  • add power seq fail log to BMC
  • add ac log in blackbox
  • add VR category classification feature.
  • fix mp29816a driver
  • add function to change mp2971 half-divider enable
  • add function to change mp2971 OVP1 threshold
  • add ASIC error to blackbox
  • send thermtrip and HBM cattrip event to BMC
  • add TMP75 alert event to blackbox
  • fix ASIC error blackbox format
  • fix power capping lv1 set by power
  • update mp2971_get_vout_offset() to convert VOUT_CAL_OFFSET (VID code) into mV offset
    using mp2971_vid_to_direct() delta, so shell output reflects correct offset value
  • remove vout perm setting
  • fix incorrect description of jtag_mux shell command when setting jtag mux
  • add vr smbus alert event to bmc
  • fix event status duplicate issue, move status clear from dc off to dc on
  • fix asic_mfio cli cmd input/output issue
  • fix vr pwr fault log event send wrong rail status issue
  • modify the number of log events
  • fix log index out of range
  • extend static memory

Test Plan:

  • Build code: Pass

HungYi-Li and others added 30 commits January 29, 2026 18:56
Summary:
- add rns vr dma
- add rns vr uvp/ovp enable
- add vr get page
- check vr test mode in bic start
- add vr test mode dma shell commands
- add vr test mode pmbus shell commands

Test Plan:
- Build code: Pass
Summary:
- fix typo for shell
- add adc vendor test
- fix power capping get vr power value format
- fix i2c get vr power value format
- add i2c target 0x95 0x96

Test Plan:
- Build code: Pass
Summary:
- add debug vr voltage for power capping
- add ADC info in test info

Test Plan:
- Build code: Pass
- Test with power capping function
Summary:
 - Apply upstream patch 0032-driver-pwm-add-output-open-drain-support.patch.
 - Configure pwm1 and pwm6 devicetree nodes to enable drive-open-drain (change output from push-pull to open-drain).
Test Plan:
 - Build: Pass
…xit test mode

Summary:
- modified HAMSA_AVDD_PCIE slow ocp to 50A in test mode
- add setting Vout to default when exit test mode

Test Plan:
- Build code: Pass
Summary:
- add dynamic change polling rate

Test Plan:
- Build code: Pass
- Test with power capping function
Summary:
- fix the sensor name rule

Test Plan:
- Build code: Pass
- Print the sensor name
Summary:
- change the bootstrap default value (T17CISB-990)

Test Plan:
- Build code: Pass
- Print the bootstrap after set default
Summary:
- add i2c reg 0x97

Test Plan:
- Build code: Pass
- Get/Set I2C Reg 0x97
Summary:
- disable unused function

Test Plan:
- Build code: Pass
Summary:
- disable unused function

Test Plan:
- Build code: Pass
Summary:
- add vr rns access check dc status
- modify vr test mode thread stack size

Test Plan:
- Build code: Pass
Summary:
- Version commit for sb-rb-20260101

Test Plan:
Build code: Pass
Check BIC version: Pass
Summary:
- Enable float point print

Test Plan:
Build code: Pass
Print float point: Pass
Summary:
- Add shell pldm to bmc cmd

Test Plan:
Build code: Pass
Sent event to BMC: Pass
Summary:
- Enable float point print

Test Plan:
Build code: Pass
Print float point: Pass
Summary:
- fix force_read_asic_version (T17CISB-1008)
- set MUX to ASIC after done

Test Plan:
- Build code: Pass
- Test with get_fw_version force_read_asic
Summary:
- add power seq fail log to BMC
- add ac log in blackbox

Test Plan:
- Build code: Pass
- Test AC and power on seq fail
Summary:
- Add MP2971 helpers to read VOUT offset and protection thresholds (UVP/OVP1/OVP2).
- Add MP2971 total OCP read/write with rail-aware phase handling.
- Add MP2971 OVP2 action mode read/write via MFR_OVP_UVP_MODE (0x61) bits[15:14].
Test Plan:
- Build Code: Pass
- Function check: Pass
Summary:
- add function to change mp2971 half-divider enable
- add function to change mp2971 OVP1 threshold
Test Plan:
- Build code: Pass
- Function test: Pass
Summery:
 - test_mode_table and normal_mode_table in plat_vr_test_mode.c
Test plan:
 - Build code: Pass
 - Table check: Pass
Summery:
 - Update shell_vr_test_mode.c test mode default UVP value.
 - Show no action for OVP2 when test mode is enabled (MP29816C/MP2971).
Test plan:
 - Build code: Pass
Summery:
 - update uvp_threshold in vr_mps_normal_mode_table and vr_mps_test_mode_table
 - fix vr_test_mode show default wrong uvp value
Test plan:
 - Build code: Pass
YoungLi123 and others added 17 commits January 29, 2026 19:04
Summary:
- add ASIC error to blackbox
- send thermtrip and HBM cattrip event to BMC
- add TMP75 alert event to blackbox

Test Plan:
- Build code: Pass
- Test with event
Summary:
- fix ASIC error blackbox format

Test Plan:
- Build code: Pass
- Test with event
Summary:
- add MPS2971 VR test mode start/exit function to modify VR setting
Test Plan:
- Build code: Pass
Summary:
- add mps2971 set UVP threshold function
- modify vr mode setting table
Test Plan:
- Build code: Pass
- Function check: Pass
Summary:
- Version commit for sb-rb-20260201

Test Plan:
- Build code: Pass
- Check BIC version: Pass
Summary:
- fix power capping lv1 set by power

Test Plan:
- Build code: Pass
- test with get/set power capping threshold
Summary:
- Update mp2971_get_vout_offset() to convert VOUT_CAL_OFFSET (VID code) into mV offset
  using mp2971_vid_to_direct() delta, so shell output reflects correct offset value.
Test Plan:
- Build Code: Pass
- Function check: Pass
Summary:
- remove vout perm setting

Test Plan:
- Build code: Pass
- Test with perm_confg get
Summary:
- remove vout perm setting

Test Plan:
- Build code: Pass
- Test with perm_confg get
Summary:
- fix incorrect description of jtag_mux shell command when setting jtag mux

Test Plan:
- Build code: Pass
…e issue

Summary:
- add vr smbus alert event to bmc
- fix event status duplicate issue, move status clear from dc off to dc on

Test Plan:
- Build code: Pass
Summary:
- modify the number of log events
- fix log index out of range

Test Plan:
- Build code: Pass
Summary:
- Version commit for sb-rb-20260301

Test Plan:
Build code: Pass
Check BIC version: Pass
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 29, 2026
@facebook-github-bot
Copy link
Contributor

@khoung76642 has updated the pull request. You must reimport the pull request before landing.

@meta-codesync
Copy link

meta-codesync bot commented Jan 29, 2026

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D91775411. (Because this pull request was imported automatically, there will not be any future comments.)

@facebook-github-bot
Copy link
Contributor

@khoung76642 has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@khoung76642 has updated the pull request. You must reimport the pull request before landing.

@khoung76642
Copy link
Contributor Author

*Regarding the following errors, we have checked and confirmed that they are from common code, which will be redefined by users in the platform code:
common/service/sensor/pldm_sensor.c:125:50:Condition 'sensor_pdr_index>=pldm_sensor_count' is always true
common/service/sensor/pldm_sensor.c:425:24:Condition 'pldm_sensor_count<=0' is always true
common/service/sensor/pldm_sensor.c:432:34:Condition 'pldm_sensor_list[thread_id]==NULL' is always true
common/service/sensor/pldm_sensor.c:495:13:Condition 'stack==NULL' is always true
common/service/sensor/pldm_sensor.c:500:9:Redundant initialization for 'stack'. The initialized value is overwritten before it is read.
common/service/sensor/pldm_sensor.c:501:14:Redundant initialization for 'stack_size'. The initialized value is overwritten before it is read.
common/shell/commands/sensor_shell.c:367:8:Variable 'keyword' can be declared as pointer to const

@meta-codesync
Copy link

meta-codesync bot commented Jan 29, 2026

This pull request has been merged in e05da23.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants