chore(deps): remove cross-fetch dependency#521
chore(deps): remove cross-fetch dependency#521jonkoops wants to merge 1 commit intofacebook:mainfrom
cross-fetch dependency#521Conversation
|
Hi @jonkoops! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
| ] | ||
| }, | ||
| "dependencies": { | ||
| "cross-fetch": "^3.1.5", |
There was a problem hiding this comment.
Side-note, I am not sure why this was included as a dependency, it seems like this was only ever used during testing.
There was a problem hiding this comment.
fbjs was created to support FB projects, goal being to provide the same core/shared libraries we had internally. fetch was one of those things but had too much internal-specific code so it was a "forked" implementation here. It relied on cross-fetch and re-exported it (as you saw) but was not otherwise used directly.
jonkoops
force-pushed
the
remove-cross-fetch
branch
from
d0d47f1 to
50e174d
Compare
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
3 participants
Removes the
cross-fetchdependency from the package, as the Fetch API is now supported in Node.js.Closes #520