Convert directory fbcode/opensource to use the Ruff Formatter #277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: X-link: facebook/fb303#59 Converts the directory specified to use the Ruff formatter in pyfmt ruff_dog If this diff causes merge conflicts when rebasing, please run `hg status -n -0 --change . -I '**/*.{py,pyi}' | xargs -0 arc pyfmt` on your diff, and amend any changes before rebasing onto latest. That should help reduce or eliminate any merge conflicts. allow-large-files Reviewed By: amyreese Differential Revision: D64265365
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64265365 |
tpolasek
pushed a commit
to tpolasek/folly
that referenced
this pull request
Oct 18, 2024
Summary: X-link: facebook/fboss#277 X-link: facebook/fb303#59 Converts the directory specified to use the Ruff formatter in pyfmt ruff_dog If this diff causes merge conflicts when rebasing, please run `hg status -n -0 --change . -I '**/*.{py,pyi}' | xargs -0 arc pyfmt` on your diff, and amend any changes before rebasing onto latest. That should help reduce or eliminate any merge conflicts. allow-large-files Reviewed By: amyreese Differential Revision: D64265365
tpolasek
pushed a commit
to tpolasek/hhvm
that referenced
this pull request
Oct 18, 2024
Summary: X-link: facebook/folly#2318 X-link: facebook/fboss#277 X-link: facebook/fb303#59 Converts the directory specified to use the Ruff formatter in pyfmt ruff_dog If this diff causes merge conflicts when rebasing, please run `hg status -n -0 --change . -I '**/*.{py,pyi}' | xargs -0 arc pyfmt` on your diff, and amend any changes before rebasing onto latest. That should help reduce or eliminate any merge conflicts. allow-large-files Reviewed By: amyreese Differential Revision: D64265365
tpolasek
pushed a commit
to tpolasek/mvfst
that referenced
this pull request
Oct 18, 2024
Summary: X-link: facebook/hhvm#9522 X-link: facebook/folly#2318 X-link: facebook/fboss#277 X-link: facebook/fb303#59 Converts the directory specified to use the Ruff formatter in pyfmt ruff_dog If this diff causes merge conflicts when rebasing, please run `hg status -n -0 --change . -I '**/*.{py,pyi}' | xargs -0 arc pyfmt` on your diff, and amend any changes before rebasing onto latest. That should help reduce or eliminate any merge conflicts. allow-large-files Reviewed By: amyreese Differential Revision: D64265365
tpolasek
pushed a commit
to tpolasek/openr
that referenced
this pull request
Oct 18, 2024
Summary: X-link: facebook/mvfst#358 X-link: facebook/hhvm#9522 X-link: facebook/folly#2318 X-link: facebook/fboss#277 X-link: facebook/fb303#59 Converts the directory specified to use the Ruff formatter in pyfmt ruff_dog If this diff causes merge conflicts when rebasing, please run `hg status -n -0 --change . -I '**/*.{py,pyi}' | xargs -0 arc pyfmt` on your diff, and amend any changes before rebasing onto latest. That should help reduce or eliminate any merge conflicts. allow-large-files Reviewed By: amyreese Differential Revision: D64265365
tpolasek
pushed a commit
to tpolasek/proxygen
that referenced
this pull request
Oct 18, 2024
Summary: X-link: facebook/openr#156 X-link: facebook/mvfst#358 X-link: facebook/hhvm#9522 X-link: facebook/folly#2318 X-link: facebook/fboss#277 X-link: facebook/fb303#59 Converts the directory specified to use the Ruff formatter in pyfmt ruff_dog If this diff causes merge conflicts when rebasing, please run `hg status -n -0 --change . -I '**/*.{py,pyi}' | xargs -0 arc pyfmt` on your diff, and amend any changes before rebasing onto latest. That should help reduce or eliminate any merge conflicts. allow-large-files Reviewed By: amyreese Differential Revision: D64265365
tpolasek
pushed a commit
to tpolasek/sapling
that referenced
this pull request
Oct 18, 2024
Summary: X-link: facebook/proxygen#523 X-link: facebook/openr#156 X-link: facebook/mvfst#358 X-link: facebook/hhvm#9522 X-link: facebook/folly#2318 X-link: facebook/fboss#277 X-link: facebook/fb303#59 Converts the directory specified to use the Ruff formatter in pyfmt ruff_dog If this diff causes merge conflicts when rebasing, please run `hg status -n -0 --change . -I '**/*.{py,pyi}' | xargs -0 arc pyfmt` on your diff, and amend any changes before rebasing onto latest. That should help reduce or eliminate any merge conflicts. allow-large-files Reviewed By: amyreese Differential Revision: D64265365
tpolasek
pushed a commit
to tpolasek/wangle
that referenced
this pull request
Oct 18, 2024
Summary: X-link: facebook/sapling#968 X-link: facebook/proxygen#523 X-link: facebook/openr#156 X-link: facebook/mvfst#358 X-link: facebook/hhvm#9522 X-link: facebook/folly#2318 X-link: facebook/fboss#277 X-link: facebook/fb303#59 Converts the directory specified to use the Ruff formatter in pyfmt ruff_dog If this diff causes merge conflicts when rebasing, please run `hg status -n -0 --change . -I '**/*.{py,pyi}' | xargs -0 arc pyfmt` on your diff, and amend any changes before rebasing onto latest. That should help reduce or eliminate any merge conflicts. allow-large-files Reviewed By: amyreese Differential Revision: D64265365
tpolasek
pushed a commit
to tpolasek/watchman
that referenced
this pull request
Oct 18, 2024
Summary: X-link: facebook/wangle#239 X-link: facebook/sapling#968 X-link: facebook/proxygen#523 X-link: facebook/openr#156 X-link: facebook/mvfst#358 X-link: facebook/hhvm#9522 X-link: facebook/folly#2318 X-link: facebook/fboss#277 X-link: facebook/fb303#59 Converts the directory specified to use the Ruff formatter in pyfmt ruff_dog If this diff causes merge conflicts when rebasing, please run `hg status -n -0 --change . -I '**/*.{py,pyi}' | xargs -0 arc pyfmt` on your diff, and amend any changes before rebasing onto latest. That should help reduce or eliminate any merge conflicts. allow-large-files Reviewed By: amyreese Differential Revision: D64265365
tpolasek
pushed a commit
to tpolasek/edencommon
that referenced
this pull request
Oct 18, 2024
Summary: X-link: facebook/watchman#1248 X-link: facebook/wangle#239 X-link: facebook/sapling#968 X-link: facebook/proxygen#523 X-link: facebook/openr#156 X-link: facebook/mvfst#358 X-link: facebook/hhvm#9522 X-link: facebook/folly#2318 X-link: facebook/fboss#277 X-link: facebook/fb303#59 Converts the directory specified to use the Ruff formatter in pyfmt ruff_dog If this diff causes merge conflicts when rebasing, please run `hg status -n -0 --change . -I '**/*.{py,pyi}' | xargs -0 arc pyfmt` on your diff, and amend any changes before rebasing onto latest. That should help reduce or eliminate any merge conflicts. allow-large-files Reviewed By: amyreese Differential Revision: D64265365
tpolasek
pushed a commit
to tpolasek/moxygen
that referenced
this pull request
Oct 18, 2024
Summary: X-link: facebookexperimental/edencommon#21 X-link: facebook/watchman#1248 X-link: facebook/wangle#239 X-link: facebook/sapling#968 X-link: facebook/proxygen#523 X-link: facebook/openr#156 X-link: facebook/mvfst#358 X-link: facebook/hhvm#9522 X-link: facebook/folly#2318 X-link: facebook/fboss#277 X-link: facebook/fb303#59 Converts the directory specified to use the Ruff formatter in pyfmt ruff_dog If this diff causes merge conflicts when rebasing, please run `hg status -n -0 --change . -I '**/*.{py,pyi}' | xargs -0 arc pyfmt` on your diff, and amend any changes before rebasing onto latest. That should help reduce or eliminate any merge conflicts. allow-large-files Reviewed By: amyreese Differential Revision: D64265365
tpolasek
pushed a commit
to tpolasek/rust-shed
that referenced
this pull request
Oct 18, 2024
Summary: X-link: facebookexperimental/moxygen#3 X-link: facebookexperimental/edencommon#21 X-link: facebook/watchman#1248 X-link: facebook/wangle#239 X-link: facebook/sapling#968 X-link: facebook/proxygen#523 X-link: facebook/openr#156 X-link: facebook/mvfst#358 X-link: facebook/hhvm#9522 X-link: facebook/folly#2318 X-link: facebook/fboss#277 X-link: facebook/fb303#59 Converts the directory specified to use the Ruff formatter in pyfmt ruff_dog If this diff causes merge conflicts when rebasing, please run `hg status -n -0 --change . -I '**/*.{py,pyi}' | xargs -0 arc pyfmt` on your diff, and amend any changes before rebasing onto latest. That should help reduce or eliminate any merge conflicts. allow-large-files Reviewed By: amyreese Differential Revision: D64265365
tpolasek
pushed a commit
to tpolasek/fizz
that referenced
this pull request
Oct 18, 2024
Summary: X-link: facebookexperimental/rust-shed#59 X-link: facebookexperimental/moxygen#3 X-link: facebookexperimental/edencommon#21 X-link: facebook/watchman#1248 X-link: facebook/wangle#239 X-link: facebook/sapling#968 X-link: facebook/proxygen#523 X-link: facebook/openr#156 X-link: facebook/mvfst#358 X-link: facebook/hhvm#9522 X-link: facebook/folly#2318 X-link: facebook/fboss#277 X-link: facebook/fb303#59 Converts the directory specified to use the Ruff formatter in pyfmt ruff_dog If this diff causes merge conflicts when rebasing, please run `hg status -n -0 --change . -I '**/*.{py,pyi}' | xargs -0 arc pyfmt` on your diff, and amend any changes before rebasing onto latest. That should help reduce or eliminate any merge conflicts. allow-large-files Reviewed By: amyreese Differential Revision: D64265365
tpolasek
pushed a commit
to tpolasek/hsthrift
that referenced
this pull request
Oct 18, 2024
Summary: X-link: facebookincubator/fizz#148 X-link: facebookexperimental/rust-shed#59 X-link: facebookexperimental/moxygen#3 X-link: facebookexperimental/edencommon#21 X-link: facebook/watchman#1248 X-link: facebook/wangle#239 X-link: facebook/sapling#968 X-link: facebook/proxygen#523 X-link: facebook/openr#156 X-link: facebook/mvfst#358 X-link: facebook/hhvm#9522 X-link: facebook/folly#2318 X-link: facebook/fboss#277 X-link: facebook/fb303#59 Converts the directory specified to use the Ruff formatter in pyfmt ruff_dog If this diff causes merge conflicts when rebasing, please run `hg status -n -0 --change . -I '**/*.{py,pyi}' | xargs -0 arc pyfmt` on your diff, and amend any changes before rebasing onto latest. That should help reduce or eliminate any merge conflicts. allow-large-files Reviewed By: amyreese Differential Revision: D64265365
tpolasek
pushed a commit
to tpolasek/katran
that referenced
this pull request
Oct 18, 2024
Summary: X-link: facebookincubator/hsthrift#141 X-link: facebookincubator/fizz#148 X-link: facebookexperimental/rust-shed#59 X-link: facebookexperimental/moxygen#3 X-link: facebookexperimental/edencommon#21 X-link: facebook/watchman#1248 X-link: facebook/wangle#239 X-link: facebook/sapling#968 X-link: facebook/proxygen#523 X-link: facebook/openr#156 X-link: facebook/mvfst#358 X-link: facebook/hhvm#9522 X-link: facebook/folly#2318 X-link: facebook/fboss#277 X-link: facebook/fb303#59 Converts the directory specified to use the Ruff formatter in pyfmt ruff_dog If this diff causes merge conflicts when rebasing, please run `hg status -n -0 --change . -I '**/*.{py,pyi}' | xargs -0 arc pyfmt` on your diff, and amend any changes before rebasing onto latest. That should help reduce or eliminate any merge conflicts. allow-large-files Reviewed By: amyreese Differential Revision: D64265365
raghav-nexthop
pushed a commit
to nexthop-ai/fboss
that referenced
this pull request
Feb 6, 2026
…vice for FBOSS platform_manager (facebook#277) <!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. --> **Pre-submission checklist** - [x] I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running `pip install -r requirements-dev.txt && pre-commit install` - [x] `pre-commit run` # Summary Upgraded FBOSS Distro to support systemd services and add `systemd` service integration for `platform_manager` to enable automatic startup on boot. <!-- Explain the motivation for making this change and any other context that you think would help reviewers of your code. What existing problem does the pull request solve? --> - Add `services/platform_manager.service` systemd unit file - Update `build_image_in_container.sh` to copy service files from `services/` directory to the root overlay - Update `config.sh` to enable `platform_manager.service` during image build # Test Plan <!-- Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes the user interface. How exactly did you verify that your PR solves the issue you wanted to solve? --> - Built PXE and ONIE images successfully - Verified service installs and enables correctly - Confirmed journald logging works <!-- If a relevant Github issue exists for this PR, please make sure you link that issue to this PR --> ``` [root@gold222 ~]# systemctl status platform_manager.service platform_manager.service - FBOSS Platform Manager Loaded: loaded (/usr/lib/systemd/system/platform_manager.service; enabled; preset: disabled) ``` ``` [root@gold222 fboss]# journalctl -u platform_manager ... Jan 09 07:53:25 gold222 systemd[1]: platform_manager.service: Scheduled restart job, restart counter is at 5. Jan 09 07:53:25 gold222 systemd[1]: Stopped FBOSS Platform Manager. Jan 09 07:53:25 gold222 systemd[1]: Started FBOSS Platform Manager. Jan 09 07:53:25 gold222 platform_manager[1112]: I0109 07:53:25.284380 1112 PlatformNameLib.cpp:56] Getting platform na me from bios using dmidecode ... Jan 09 07:53:25 gold222 platform_manager[1112]: I0109 07:53:25.286804 1112 PlatformNameLib.cpp:65] Platform name infer red from bios: NH-4010 Jan 09 07:53:25 gold222 platform_manager[1112]: I0109 07:53:25.286823 1112 PlatformNameLib.cpp:67] Platform name mappe d: NH-4010 ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: facebook/fb303#59
Converts the directory specified to use the Ruff formatter in pyfmt
ruff_dog
If this diff causes merge conflicts when rebasing, please run
hg status -n -0 --change . -I '**/*.{py,pyi}' | xargs -0 arc pyfmton your diff, and amend any changes before rebasing onto latest.
That should help reduce or eliminate any merge conflicts.
allow-large-files
Reviewed By: amyreese
Differential Revision: D64265365