Test disabled reverse relations #2088
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yangdanny97
approved these changes
Jan 13, 2026
Contributor
yangdanny97
left a comment
yangdanny97
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
This comment has been minimized.
This comment has been minimized.
migeed-z
added a commit
to migeed-z/pyrefly
that referenced
this pull request
Jan 13, 2026
Summary: We can use the "+" symbol to avoid creating a reverse relation. This is important to test so we can make sure we are avoiding creating that field if it is not needed Reviewed By: aleivag, yangdanny97 Differential Revision: D90517596
migeed-z
force-pushed
the
export-D90517596
branch
from
743976e to
b92dba1
Compare
This comment has been minimized.
This comment has been minimized.
migeed-z
added a commit
to migeed-z/pyrefly
that referenced
this pull request
Jan 13, 2026
Summary: We can use the "+" symbol to avoid creating a reverse relation. This is important to test so we can make sure we are avoiding creating that field if it is not needed Reviewed By: aleivag, yangdanny97 Differential Revision: D90517596
migeed-z
added a commit
to migeed-z/pyrefly
that referenced
this pull request
Jan 13, 2026
Summary: We can use the "+" symbol to avoid creating a reverse relation. This is important to test so we can make sure we are avoiding creating that field if it is not needed Reviewed By: aleivag, yangdanny97 Differential Revision: D90517596
migeed-z
added a commit
to migeed-z/pyrefly
that referenced
this pull request
Jan 13, 2026
Summary: We can use the "+" symbol to avoid creating a reverse relation. This is important to test so we can make sure we are avoiding creating that field if it is not needed Reviewed By: aleivag, yangdanny97 Differential Revision: D90517596
migeed-z
added a commit
to migeed-z/pyrefly
that referenced
this pull request
Jan 13, 2026
Summary: We can use the "+" symbol to avoid creating a reverse relation. This is important to test so we can make sure we are avoiding creating that field if it is not needed Reviewed By: aleivag, yangdanny97 Differential Revision: D90517596
migeed-z
force-pushed
the
export-D90517596
branch
from
b92dba1 to
97283e5
Compare
This comment has been minimized.
This comment has been minimized.
migeed-z
added a commit
to migeed-z/pyrefly
that referenced
this pull request
Jan 13, 2026
Summary: We can use the "+" symbol to avoid creating a reverse relation. This is important to test so we can make sure we are avoiding creating that field if it is not needed Reviewed By: aleivag, yangdanny97 Differential Revision: D90517596
migeed-z
added a commit
to migeed-z/pyrefly
that referenced
this pull request
Jan 13, 2026
Summary: We can use the "+" symbol to avoid creating a reverse relation. This is important to test so we can make sure we are avoiding creating that field if it is not needed Reviewed By: aleivag, yangdanny97 Differential Revision: D90517596
migeed-z
force-pushed
the
export-D90517596
branch
from
97283e5 to
80ca25e
Compare
migeed-z
added a commit
to migeed-z/pyrefly
that referenced
this pull request
Jan 13, 2026
Summary: We can use the "+" symbol to avoid creating a reverse relation. This is important to test so we can make sure we are avoiding creating that field if it is not needed Reviewed By: aleivag, yangdanny97 Differential Revision: D90517596
migeed-z
added a commit
to migeed-z/pyrefly
that referenced
this pull request
Jan 13, 2026
Summary: We can use the "+" symbol to avoid creating a reverse relation. This is important to test so we can make sure we are avoiding creating that field if it is not needed Reviewed By: aleivag, yangdanny97 Differential Revision: D90517596
This comment has been minimized.
This comment has been minimized.
…rd) (facebook#2087) Summary: Here, we test the related_name keyword which allows us to customize the reverse relation Reviewed By: aleivag Differential Revision: D90517278
Summary: We can use the "+" symbol to avoid creating a reverse relation. This is important to test so we can make sure we are avoiding creating that field if it is not needed Reviewed By: aleivag, yangdanny97 Differential Revision: D90517596
migeed-z
force-pushed
the
export-D90517596
branch
from
80ca25e to
5360ddf
Compare
migeed-z
added a commit
to migeed-z/pyrefly
that referenced
this pull request
Jan 13, 2026
Summary: We can use the "+" symbol to avoid creating a reverse relation. This is important to test so we can make sure we are avoiding creating that field if it is not needed Reviewed By: aleivag, yangdanny97 Differential Revision: D90517596
migeed-z
added a commit
to migeed-z/pyrefly
that referenced
this pull request
Jan 13, 2026
Summary: We can use the "+" symbol to avoid creating a reverse relation. This is important to test so we can make sure we are avoiding creating that field if it is not needed Reviewed By: aleivag, yangdanny97 Differential Revision: D90517596
migeed-z
added a commit
to migeed-z/pyrefly
that referenced
this pull request
Jan 13, 2026
Summary: We can use the "+" symbol to avoid creating a reverse relation. This is important to test so we can make sure we are avoiding creating that field if it is not needed Reviewed By: aleivag, yangdanny97 Differential Revision: D90517596
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
meta-codesync bot
pushed a commit
that referenced
this pull request
Jan 13, 2026
Summary: Pull Request resolved: #2088 We can use the "+" symbol to avoid creating a reverse relation. This is important to test so we can make sure we are avoiding creating that field if it is not needed Reviewed By: aleivag, yangdanny97 Differential Revision: D90517596 fbshipit-source-id: 3a1f16fd79d3267dfe37ea40b7082cd25a7d80ed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: We can use the "+" symbol to avoid creating a reverse relation. This is important to test so we can make sure we are avoiding creating that field if it is not needed
Reviewed By: aleivag, yangdanny97
Differential Revision: D90517596