Remove unused variable single_column_family_mode_#10078
Closed
riversand963 wants to merge 1 commit intofacebook:mainfrom
Closed
Remove unused variable single_column_family_mode_#10078riversand963 wants to merge 1 commit intofacebook:mainfrom
single_column_family_mode_#10078riversand963 wants to merge 1 commit intofacebook:mainfrom
Conversation
Contributor
|
@riversand963 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
tabokie
pushed a commit
to tabokie/rocksdb
that referenced
this pull request
Jul 22, 2022
Summary: This variable is actually not being used for anything meaningful, thus remove it. This can make facebook#7516 slightly simpler by reducing the amount of state that must be made lock-free. Pull Request resolved: facebook#10078 Test Plan: make check Reviewed By: ajkr Differential Revision: D36779817 Pulled By: riversand963 fbshipit-source-id: ffb0d9ad6149616917ae5e02bb28102cb90fc406 Signed-off-by: tabokie <xy.tao@outlook.com>
tabokie
pushed a commit
to tikv/rocksdb
that referenced
this pull request
Jul 25, 2022
Summary: This variable is actually not being used for anything meaningful, thus remove it. This can make facebook#7516 slightly simpler by reducing the amount of state that must be made lock-free. Pull Request resolved: facebook#10078 Test Plan: make check Reviewed By: ajkr Differential Revision: D36779817 Pulled By: riversand963 fbshipit-source-id: ffb0d9ad6149616917ae5e02bb28102cb90fc406 Signed-off-by: tabokie <xy.tao@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This variable is actually not being used for anything meaningful, thus remove it.
This can make #7516 slightly simpler by reducing the amount of state that must be made lock-free.
Test plan:
make check