WIP - max_background_remote_compactions#14378
Draft
jaykorean wants to merge 1 commit intofacebook:mainfrom
Draft
WIP - max_background_remote_compactions#14378jaykorean wants to merge 1 commit intofacebook:mainfrom
jaykorean wants to merge 1 commit intofacebook:mainfrom
Conversation
✅ clang-tidy: No findings on changed linesCompleted in 266.8s. |
hx235
reviewed
Feb 25, 2026
| // Default: 0 | ||
| // | ||
| // Dynamically changeable through SetDBOptions() API. | ||
| int max_background_remote_compactions = 0; |
Contributor
There was a problem hiding this comment.
See max_background_compactions/flush above for its DEPRECATED note. I was going to remove them in the near future. RocksDB has been on a journey since then or even earlier than that to minimize exposing low-level configuration. We can talk more about the motivation behind this PR and see what are the other approaches if you want.
hx235
requested changes
Feb 25, 2026
Contributor
There was a problem hiding this comment.
If this is becoming an official work, let's discuss more about #14378 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.