Complete WriteBufferManager Java API with monitoring methods#14392
Open
mike-evolved wants to merge 3 commits intofacebook:mainfrom
Open
Complete WriteBufferManager Java API with monitoring methods#14392mike-evolved wants to merge 3 commits intofacebook:mainfrom
mike-evolved wants to merge 3 commits intofacebook:mainfrom
Conversation
✅ clang-tidy: No findings on changed linesCompleted in 0.0s. |
hx235
requested changes
Mar 8, 2026
Contributor
hx235
left a comment
There was a problem hiding this comment.
Could you fix the format error https://github.com/facebook/rocksdb/actions/runs/22458935067/job/65833367780?pr=14392 others look good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds 10 missing methods to WriteBufferManager Java API.
Changes
enabled(),costToCache(),memoryUsage(),mutableMemtableMemoryUsage(),dummyEntriesInCacheUsage(),bufferSize()setBufferSize(),setAllowStall()isStallActive(),isStallThresholdExceeded()Previously Java users could only create WriteBufferManager but couldn't monitor memory usage or adjust settings.
Example