Disable iteration in crash test when trie UDI is enabled#14430
Open
xingbowang wants to merge 1 commit intofacebook:mainfrom
Open
Disable iteration in crash test when trie UDI is enabled#14430xingbowang wants to merge 1 commit intofacebook:mainfrom
xingbowang wants to merge 1 commit intofacebook:mainfrom
Conversation
Summary: Trie UDI (UserDefinedIndex) does not support SeekToFirst/SeekToLast. The crash test already disabled prefix scanning (prefixpercent=0) when use_trie_index=1, but iteration (iterpercent) was still enabled. During iteration, LevelIterator::SkipEmptyFileForward() internally calls file_iter_.SeekToFirst() when Next() crosses SST file boundaries within a level. This propagates to UserDefinedIndexIteratorWrapper::SeekToFirst() which returns NotSupported, causing "Iterator diverged from control iterator" / "VerifyIterator failed" errors across many crash test variants. Fixed by also setting iterpercent=0 when use_trie_index=1 and redistributing the percentage to reads, matching the existing pattern for prefixpercent. Differential Revision: D95410767
|
@xingbowang has exported this pull request. If you are a Meta employee, you can view the originating Diff in D95410767. |
✅ clang-tidy: No findings on changed linesCompleted in 0.0s. |
|
@xingbowang has imported this pull request. If you are a Meta employee, you can view this in D95410767. |
Contributor
|
I see internally the diff was abandoned. Can you explain (and close this PR)? @xingbowang |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Trie UDI (UserDefinedIndex) does not support SeekToFirst/SeekToLast.
The crash test already disabled prefix scanning (prefixpercent=0) when
use_trie_index=1, but iteration (iterpercent) was still enabled.
During iteration, LevelIterator::SkipEmptyFileForward() internally calls
file_iter_.SeekToFirst() when Next() crosses SST file boundaries within
a level. This propagates to UserDefinedIndexIteratorWrapper::SeekToFirst()
which returns NotSupported, causing "Iterator diverged from control
iterator" / "VerifyIterator failed" errors across many crash test variants.
Fixed by also setting iterpercent=0 when use_trie_index=1 and
redistributing the percentage to reads, matching the existing pattern
for prefixpercent.
Differential Revision: D95410767