Add option to verify file checksum of output files#14433
Open
jaykorean wants to merge 3 commits intofacebook:mainfrom
Open
Add option to verify file checksum of output files#14433jaykorean wants to merge 3 commits intofacebook:mainfrom
jaykorean wants to merge 3 commits intofacebook:mainfrom
Conversation
✅ clang-tidy: No findings on changed linesCompleted in 347.0s. |
|
@jaykorean has imported this pull request. If you are a Meta employee, you can view this in D95648000. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
One of the follow ups from #14103. Users will have the option to verify file checksums for all compaction output files before they are installed. This feature helps prevent corrupted SST files from being added to the LSM tree.
Test Plan
Unit test added