Rename IsExpectedTxnLockTimeout to IsExpectedTxnError#14441
Closed
xingbowang wants to merge 1 commit intofacebook:mainfrom
Closed
Rename IsExpectedTxnLockTimeout to IsExpectedTxnError#14441xingbowang wants to merge 1 commit intofacebook:mainfrom
xingbowang wants to merge 1 commit intofacebook:mainfrom
Conversation
The function handles more than just lock timeouts — it also covers TryAgain from optimistic transactions. Rename it and update the comment to reflect its broader scope.
|
@xingbowang has imported this pull request. If you are a Meta employee, you can view this in D95877799. |
✅ clang-tidy: No findings on changed linesCompleted in 62.3s. |
hx235
approved these changes
Mar 10, 2026
|
@xingbowang merged this pull request in 26aff32. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The function handles more than just lock timeouts — it also covers TryAgain from optimistic transactions. Rename it and update the comment to reflect its broader scope.