Fix close(-1) on failed open in btrfs rename fsync path#14443
Open
omkarhgawde wants to merge 1 commit intofacebook:mainfrom
Open
Fix close(-1) on failed open in btrfs rename fsync path#14443omkarhgawde wants to merge 1 commit intofacebook:mainfrom
omkarhgawde wants to merge 1 commit intofacebook:mainfrom
Conversation
|
@omkarhgawde has exported this pull request. If you are a Meta employee, you can view the originating Diff in D95303407. |
✅ clang-tidy: No findings on changed linesCompleted in 70.6s. |
xingbowang
approved these changes
Mar 10, 2026
omkarhgawde
added a commit
to omkarhgawde/rocksdb
that referenced
this pull request
Mar 10, 2026
Summary: In `PosixDirectory::FsyncWithDirOptions()`, when handling btrfs file rename syncing, if `open()` fails and `fd` is -1, the code unconditionally calls `close(fd)`. Calling `close(-1)` is undefined behavior per POSIX (returns EBADF on Linux), and overwrites the original meaningful open error with a misleading "While closing file after fsync" error message. Fix: Guard the `close()` call with `fd >= 0`. Reviewed By: xingbowang Differential Revision: D95303407
omkarhgawde
force-pushed
the
export-D95303407
branch
from
885c4e7 to
9b88c6c
Compare
Summary: Pull Request resolved: facebook#14443 In `PosixDirectory::FsyncWithDirOptions()`, when handling btrfs file rename syncing, if `open()` fails and `fd` is -1, the code unconditionally calls `close(fd)`. Calling `close(-1)` is undefined behavior per POSIX (returns EBADF on Linux), and overwrites the original meaningful open error with a misleading "While closing file after fsync" error message. Fix: Guard the `close()` call with `fd >= 0`. Reviewed By: xingbowang Differential Revision: D95303407
omkarhgawde
force-pushed
the
export-D95303407
branch
from
9b88c6c to
7cf4ace
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
In
PosixDirectory::FsyncWithDirOptions(), when handling btrfs file renamesyncing, if
open()fails andfdis -1, the code unconditionally callsclose(fd). Callingclose(-1)is undefined behavior per POSIX (returnsEBADF on Linux), and overwrites the original meaningful open error with a
misleading "While closing file after fsync" error message.
Fix: Guard the
close()call withfd >= 0.Differential Revision: D95303407