Fix memory leak on error in C API create_column_family#14447
Open
omkarhgawde wants to merge 1 commit intofacebook:mainfrom
Open
Fix memory leak on error in C API create_column_family#14447omkarhgawde wants to merge 1 commit intofacebook:mainfrom
omkarhgawde wants to merge 1 commit intofacebook:mainfrom
Conversation
Summary: `rocksdb_create_column_family()` and `rocksdb_transactiondb_create_column_family()` allocate a `rocksdb_column_family_handle_t` but always return it even when `CreateColumnFamily()` fails. This leaks the handle and returns an object with an indeterminate `rep` pointer. Other similar functions like `rocksdb_create_column_family_with_import()` correctly delete the handle and return nullptr on error. Fix: Initialize `handle->rep = nullptr`, check `SaveError()` return value, and on error delete the handle and return nullptr. Differential Revision: D95303444
|
@omkarhgawde has exported this pull request. If you are a Meta employee, you can view the originating Diff in D95303444. |
✅ clang-tidy: No findings on changed linesCompleted in 54.2s. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
rocksdb_create_column_family()androcksdb_transactiondb_create_column_family()allocate arocksdb_column_family_handle_tbut always return it even whenCreateColumnFamily()fails. This leaks the handle and returns an objectwith an indeterminate
reppointer. Other similar functions likerocksdb_create_column_family_with_import()correctly delete the handleand return nullptr on error.
Fix: Initialize
handle->rep = nullptr, checkSaveError()return value,and on error delete the handle and return nullptr.
Differential Revision: D95303444