This repository was archived by the owner on Sep 26, 2018. It is now read-only.
Event and Notification Feature:#87
Open
sharma-sagar wants to merge 1 commit intofacebookarchive:masterfrom
Open
Event and Notification Feature:#87sharma-sagar wants to merge 1 commit intofacebookarchive:masterfrom
sharma-sagar wants to merge 1 commit intofacebookarchive:masterfrom
Conversation
sharma-sagar
commented
Nov 6, 2017
sharma-sagar
commented
- message for subscriber as mapped or automatic events (Both types included) can be added.
- editing a existing message for subscriber.
- auto translations of every new message in every language (that too editable) for BTS
- each BTS will have its own language and will have only translations for same.
* message for subscriber as mapped or automatic events (Both types included) can be added. * editing a existing message for subscriber. * auto translations of every new message in every language (that too editable) for BTS * each BTS will have its own language and will have only translations for same.
shaddi
suggested changes
May 22, 2018
Contributor
shaddi
left a comment
shaddi
left a comment
There was a problem hiding this comment.
This is an interesting feature, thanks for adding. Apologies for the delay in starting to review -- it's a pretty big change for a single commit. Could you break this up into more incremental revisions so it's easier to see what the impact is? Also, could you include screenshots for UI that you introduce? Thank you!
| "crossed %(credit)s You can transfer upto" | ||
| " %(transfer)s.", | ||
| } | ||
| # TODO(sharma-sagar): After above below will be dead code below (remove later) |
Contributor
There was a problem hiding this comment.
Please remove dead code, rather than leaving in.
| Note what this does -- it's passing in a string to the script, which in turn | ||
| needs to look it up and return some sensible result. This file is where we | ||
| actually keep track of the various strings used in the dialplan/chatplan. | ||
| <action application="python" data='endaga_notification 'any key in Base_MESSAGES' % {"number": ${vbts_callerid}}'/> |
Contributor
There was a problem hiding this comment.
Please provide a working example for documentation purposes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.