Conversation
|
Hi @offcall! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
1 similar comment
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
2ca6917 to
eb9ca46
Compare
a0c7b8b to
68f3611
Compare
|
Will this get merged? |
Summary
After this fix #2035
The composition mode began to break entities, this is because composedChars contains the text of the entire block (it causes unexpected behavior, since the entity text differs from its code), and not just the entered characters
My PR fixes this: gets the typed characters and inserts them in the right place



Tests
!need to replace old tests because they now depend on getSelection