Conversation
…anipulation In mainline 4.4 the ioctl() callback in the DM target has been removed in favour of a prepare_ioctl() which selects the underlying device, all ioctls are assume to apply to that. In discussions with upstream on resolving this it was suggested that the correct mechanism for this kind of target focussed ioctl is actually DM target messages. This patch converts the blacklist/whitelist manipulation over to these DM target messages. It also adds rather primative support to the flashcache_setioctl helper to switch to DM target messages when the existing ioctls are not supported (ENOTTY). This is handled by calling out to dmsetup which offers a message command to form these requests. I would envisage it would be possible to reduce flashcache_setioctl to a simple shell script in the future once there is no possibility of these tools being used with a kernel supporting the ioctl only. This should fix the hard parts of issue facebookarchive#215. fixes: facebookarchive#215 Signed-off-by: Andy Whitcroft <apw@ubuntu.com>
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
thanks for your contribution, i assume RHEL 7.3 backported some of these DM changes which mean the version test is no longer applicable? i think i'm going to add a configure-type script which detects these changes by compiling microprograms... i'll keep your pull request around to keep me honest until then. thanks again! |
|
This code did not merge successfully, could you deal with it ？@facebook-github-bot |
4 participants
No description provided.