This repository was archived by the owner on Jan 13, 2022. It is now read-only.
Fix misleading-indentation error.#227
Open
vinsonlee wants to merge 1 commit intofacebookarchive:masterfrom
Open
Fix misleading-indentation error.#227vinsonlee wants to merge 1 commit intofacebookarchive:masterfrom
vinsonlee wants to merge 1 commit intofacebookarchive:masterfrom
Conversation
flashcache_main.c: In function ‘flashcache_io_callback’:
flashcache_main.c:328:4: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
if (dmc->cache_mode == FLASHCACHE_WRITE_THROUGH)
^~
Fixes: 9cb6e3a ("Disambiguate ssd errors and disk errors on IO completion. On IO completion for the !WRITEBACK case, issue an uncached disk IO in the case of a SSD error. Patch submitted by Mohit Saxena.")
Signed-off-by: Vinson Lee <vlee@freedesktop.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
flashcache_main.c: In function ‘flashcache_io_callback’:
flashcache_main.c:328:4: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
if (dmc->cache_mode == FLASHCACHE_WRITE_THROUGH)
^~
Fixes: 9cb6e3a ("Disambiguate ssd errors and disk errors on IO completion. On IO completion for the !WRITEBACK case, issue an uncached disk IO in the case of a SSD error. Patch submitted by Mohit Saxena.")
Signed-off-by: Vinson Lee vlee@freedesktop.org