This repository was archived by the owner on Feb 12, 2022. It is now read-only.
Open
Conversation
chyzwar
force-pushed
the
remove-node-zip
branch
from
efbe24d to
3d22b18
Compare
Author
|
I pushed some changes to avoid upgrading whole lock files. Hopefully, this would make my change smal enough. |
chyzwar
changed the title
Author
|
I am getting prettier errors in other places. Should I fix these as a part of this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
node-zip has useful cli but in this case, it makes sense to use jszip directly. I did not use v3 version on jszip because it is only exposing async interface and v2 would hoist better with zip-dir.
https://github.com/daraosn/node-zip/blob/master/lib/nodezip.js
I also needed to run yarn upgrade to properly de-duplicate jszip.