Skip to content
This repository was archived by the owner on Sep 18, 2025. It is now read-only.

Open source seamless experiences backend server and streaming chrome extension#68

Open
lh5844 wants to merge 10 commits intofacebookresearch:mainfrom
lh5844:demo
Open

Open source seamless experiences backend server and streaming chrome extension#68
lh5844 wants to merge 10 commits intofacebookresearch:mainfrom
lh5844:demo

Conversation

@lh5844
Copy link
Contributor

@lh5844 lh5844 commented Aug 7, 2023

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 7, 2023
@lh5844 lh5844 marked this pull request as ready for review August 7, 2023 04:38
@annasun28
Copy link
Contributor

Hey @lh5844 , thanks for the PR! Do you mind sharing which commit in seamless-experiences you copied the changes from? Just for my future reference, since we have some changes in-flight

@lh5844
Copy link
Contributor Author

lh5844 commented Aug 8, 2023

Hey @lh5844 , thanks for the PR! Do you mind sharing which commit in seamless-experiences you copied the changes from? Just for my future reference, since we have some changes in-flight

Yup, I just added it to my pr comment, thank you for the catch!

@annasun28
Copy link
Contributor

Thanks @lh5844! I'll pull these changes to test locally, will get back to you by end of today :)

@@ -0,0 +1,33 @@
## to start the server
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lh5844 Could you update this README to reflect the steps you needed to get the server backend set up? I think you've had the most recent experience setting it up, so it would be helpful to incorporate anything you noticed which wasn't in the instructions. Also, we can remove the part about the google cloud account, and downloading the streaming models (since this is intended as a general-purpose demo).

For now, you could update the README to describe how to set up the demo for the dummy S2T/S2S models, but in the future we could switch it to e.g. the Whisper tiny model for running locally

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For context, I was hoping to test the installation from scratch to make sure there are not any unexpected installation issues for users

@justinhaaheim
Copy link
Contributor

justinhaaheim commented Aug 10, 2023

What's the timeline for open-sourcing this? What's the timeline for open-sourcing this? There's a lot of cruft and janky code in the streaming server right now, that I'd like us to clean up before we share it with the world.

@annasun28
Copy link
Contributor

What's the timeline for open-sourcing this? There's a lot of cruft and janky code in the streaming server right now, that I'd like us to clean up before we share it with the world.

It's not urgent, but we were hoping that Lucy could help with the code cleanup here? Sorry I haven't yet gone through the PR in detail to comment on which parts need cleaning up, but that was what I had in mind - wdyt @justinhaaheim ?

@justinhaaheim
Copy link
Contributor

There's a lot of work that will be done to the server in the next few weeks, and there's also some specific work I'd like us to do before we open source this code. Can we close this PR for now and re-create once we've had some time to prepare the server for open source? This code really isn't ready to land in open-source yet.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants