Open source seamless experiences backend server and streaming chrome extension#68
Open source seamless experiences backend server and streaming chrome extension#68lh5844 wants to merge 10 commits intofacebookresearch:mainfrom
Conversation
|
Hey @lh5844 , thanks for the PR! Do you mind sharing which commit in seamless-experiences you copied the changes from? Just for my future reference, since we have some changes in-flight |
Yup, I just added it to my pr comment, thank you for the catch! |
|
Thanks @lh5844! I'll pull these changes to test locally, will get back to you by end of today :) |
| @@ -0,0 +1,33 @@ | |||
| ## to start the server | |||
There was a problem hiding this comment.
@lh5844 Could you update this README to reflect the steps you needed to get the server backend set up? I think you've had the most recent experience setting it up, so it would be helpful to incorporate anything you noticed which wasn't in the instructions. Also, we can remove the part about the google cloud account, and downloading the streaming models (since this is intended as a general-purpose demo).
For now, you could update the README to describe how to set up the demo for the dummy S2T/S2S models, but in the future we could switch it to e.g. the Whisper tiny model for running locally
There was a problem hiding this comment.
For context, I was hoping to test the installation from scratch to make sure there are not any unexpected installation issues for users
|
What's the timeline for open-sourcing this? What's the timeline for open-sourcing this? There's a lot of cruft and janky code in the streaming server right now, that I'd like us to clean up before we share it with the world. |
It's not urgent, but we were hoping that Lucy could help with the code cleanup here? Sorry I haven't yet gone through the PR in detail to comment on which parts need cleaning up, but that was what I had in mind - wdyt @justinhaaheim ? |
|
There's a lot of work that will be done to the server in the next few weeks, and there's also some specific work I'd like us to do before we open source this code. Can we close this PR for now and re-create once we've had some time to prepare the server for open source? This code really isn't ready to land in open-source yet. |
resolving issue #54
seamless experiences commit from https://github.com/fairinternal/seamless-experiences/commit/472d556e46c6999cd28994e1b3ba4d185522d09a