Jacklanchantin/verifiable nonverifiable#1173
Draft
jacklanchantin wants to merge 35 commits intoonline_trainingfrom
Draft
Jacklanchantin/verifiable nonverifiable#1173jacklanchantin wants to merge 35 commits intoonline_trainingfrom
jacklanchantin wants to merge 35 commits intoonline_trainingfrom
Conversation
…2 into jacklanchantin/verifiable_nonverifiable
jacklanchantin
commented
May 9, 2025
| # dummy vllm call for syncronization # FIXME | ||
| # if self.vllm_math_reward_model is not None: | ||
| log.info("MathVerifyVerifir generate_rewards()") | ||
| dummy_rewards = generate_rewards( |
Contributor
Author
There was a problem hiding this comment.
if i check for if self.vllm_math_reward_model is not None which it will be None for non combination runs, then i get an nccl error. not sure what's happening there
…okresearch/fairseq2 into jacklanchantin/verifiable_nonverifiable
…2 into jacklanchantin/verifiable_nonverifiable
…2 into jacklanchantin/verifiable_nonverifiable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do? Please describe:
A summary of the change or the issue that is fixed.
Fixes #{issue number}
right now, we pass all prompts to the LLM reward model for synchronization. need to optimize it. e.g.:
in SuperReward:
the biggest mismatch is that non-LLM rewards all run in parallel, but with LLM ones we have to do collective call, so here we have to unify that
Does your PR introduce any breaking changes? If yes, please list them:
List of all backwards-incompatible changes.
Check list: