Frogger by arjtala · Pull Request #113 · facebookresearch/matrix

arjtala · 2025-11-14T23:36:39Z

Why ?

This PR enables frogger2 in Matrix which can be use to log to Scuba/Hive when running on Meta infra. The default fallback is to using the standard logging.Logger

How ?

Install Matrix with the relevant dependancy:

pip install fair-matrix[meta]

Test plan

Devserver:

> pytest tests/integration/utils/test_matrix_logging.py -v
============================================================================= test session starts ==============================================================================
platform linux -- Python 3.11.14, pytest-9.0.1, pluggy-1.6.0 -- /home/arjangt/.conda/envs/frogger/bin/python3.11
cachedir: .pytest_cache
rootdir: /home/arjangt/src/matrix
configfile: pyproject.toml
plugins: anyio-4.11.0, asyncio-1.3.0
asyncio: mode=Mode.STRICT, debug=False, asyncio_default_fixture_loop_scope=None, asyncio_default_test_loop_scope=function
collected 15 items                                                                                                                                                             

tests/integration/utils/test_matrix_logging.py::TestMatrixLogger::test_matrix_logger_initialization PASSED                                                               [  6%]
tests/integration/utils/test_matrix_logging.py::TestMatrixLogger::test_get_logger_returns_matrix_logger_with_forgger PASSED                                              [ 13%]
tests/integration/utils/test_matrix_logging.py::TestMatrixLogger::test_get_logger_returns_standard_logger_without_frogger PASSED                                         [ 20%]
tests/integration/utils/test_matrix_logging.py::TestMatrixLogger::test_matrix_logger_info_with_frogger PASSED                                                            [ 26%]
tests/integration/utils/test_matrix_logging.py::TestMatrixLogger::test_matrix_logger_info_without_frogger PASSED                                                         [ 33%]
tests/integration/utils/test_matrix_logging.py::TestMatrixLogger::test_matrix_logger_all_levels PASSED                                                                   [ 40%]
tests/integration/utils/test_matrix_logging.py::TestMatrixLogger::test_matrix_logger_handlers PASSED                                                                     [ 46%]
tests/integration/utils/test_matrix_logging.py::TestMatrixLogger::test_matrix_logger_set_level PASSED                                                                    [ 53%]
tests/integration/utils/test_matrix_logging.py::TestMatrixLogger::test_transmit_handles_exceptions PASSED                                                                [ 60%]
tests/integration/utils/test_matrix_logging.py::TestMatrixLoggerIntegration::test_ray_dashboard_job_logging PASSED                                                       [ 66%]
tests/integration/utils/test_matrix_logging.py::TestMatrixLoggerIntegration::test_logger_with_structured_data PASSED                                                     [ 73%]
tests/integration/utils/test_matrix_logging.py::TestMatrixLoggerWithFrogger::test_transmission PASSED                                                                    [ 80%]
tests/integration/utils/test_matrix_logging.py::TestMatrixLoggerWithFrogger::test_frogger_transmission_with_all_log_levels PASSED                                        [ 86%]
tests/integration/utils/test_matrix_logging.py::TestMatrixLoggerWithFrogger::test_frogger_transmission_with_structured_fields PASSED                                     [ 93%]
tests/integration/utils/test_matrix_logging.py::TestMatrixLoggerWithFrogger::test_verify_local_and_remote_logging_both_occur PASSED                                      [100%]

============================================================================== 15 passed in 2.59s ==============================================================================

SELECT
    FROM_UNIXTIME(time) AS date,
    nodename,
    release,
    duration_seconds,
    num_samples,
    status,
    cluster_scope,
    hashed_username,
    job_id,
    log_level,
    log_message
FROM fair_matrix_events_scuba
ORDER BY time DESC
LIMIT 10

 date                | nodename                     | release                       | duration_seconds | num_samples | status | cluster_scope | hashed_username                                                  | job_id               | log_level | log_message                    
---------------------+------------------------------+-------------------------------+------------------+-------------+--------+---------------+------------------------------------------------------------------+----------------------+-----------+--------------------------------
 2025-11-19 09:57:25 | devvm11807.vll0.facebook.com | 6.9.0-0_fbk10_0_gc5fa564d33e3 |                0 |           0 |      0 | local-node    | bb261073db8b64c7bee79b4c712c5d78a704eb330f10d08647c5703544aa9cf2 | dual_test_001        | INFO      | Dual logging verification test 
 2025-11-19 09:57:25 | devvm11807.vll0.facebook.com | 6.9.0-0_fbk10_0_gc5fa564d33e3 |                0 |           0 |      0 | local-node    | bb261073db8b64c7bee79b4c712c5d78a704eb330f10d08647c5703544aa9cf2 | test_critical        | CRITICAL  | Critical message               
 2025-11-19 09:57:25 | devvm11807.vll0.facebook.com | 6.9.0-0_fbk10_0_gc5fa564d33e3 |                0 |           0 |      0 | local-node    | bb261073db8b64c7bee79b4c712c5d78a704eb330f10d08647c5703544aa9cf2 | test_debug           | DEBUG     | Debug message                  
 2025-11-19 09:57:25 | devvm11807.vll0.facebook.com | 6.9.0-0_fbk10_0_gc5fa564d33e3 |                0 |           0 |      0 | local-node    | bb261073db8b64c7bee79b4c712c5d78a704eb330f10d08647c5703544aa9cf2 | test_error           | ERROR     | Error message                  
 2025-11-19 09:57:25 | devvm11807.vll0.facebook.com | 6.9.0-0_fbk10_0_gc5fa564d33e3 |                0 |           0 |      0 | local-node    | bb261073db8b64c7bee79b4c712c5d78a704eb330f10d08647c5703544aa9cf2 | test_info            | INFO      | Info message                   
 2025-11-19 09:57:25 | devvm11807.vll0.facebook.com | 6.9.0-0_fbk10_0_gc5fa564d33e3 |                0 |           0 |      0 | local-node    | bb261073db8b64c7bee79b4c712c5d78a704eb330f10d08647c5703544aa9cf2 | test_warning         | WARNING   | Warning message                
 2025-11-19 09:57:25 | devvm11807.vll0.facebook.com | 6.9.0-0_fbk10_0_gc5fa564d33e3 |                0 |           0 |      1 | local-node    | bb261073db8b64c7bee79b4c712c5d78a704eb330f10d08647c5703544aa9cf2 | test_job_123         | INFO      | Integration test message       
 2025-11-19 09:57:25 | devvm11807.vll0.facebook.com | 6.9.0-0_fbk10_0_gc5fa564d33e3 |                0 |        5000 |      0 | local-node    | bb261073db8b64c7bee79b4c712c5d78a704eb330f10d08647c5703544aa9cf2 | integration_test_456 | INFO      | Structured logging test        
 2025-11-19 09:56:37 | devvm11807.vll0.facebook.com | 6.9.0-0_fbk10_0_gc5fa564d33e3 |                0 |           0 |      0 | local-node    | bb261073db8b64c7bee79b4c712c5d78a704eb330f10d08647c5703544aa9cf2 | dual_test_001        | INFO      | Dual logging verification test 
 2025-11-19 09:56:37 | devvm11807.vll0.facebook.com | 6.9.0-0_fbk10_0_gc5fa564d33e3 |                0 |           0 |      0 | local-node    | bb261073db8b64c7bee79b4c712c5d78a704eb330f10d08647c5703544aa9cf2 | test_critical        | CRITICAL  | Critical message

yangli5t · 2025-11-19T02:13:52Z

pyproject.toml

      "fastgen @ git+https://github.com/dongwang218/fastgen.git"
  ]
+  meta = [
+      "frogger2 @ git+ssh://git@github.com/fairinternal/frogger2.git"


this repo is not available for public, right?

arjtala · 2025-11-19T18:10:44Z

Test logs from CoreWeave:

 date                | nodename        | release                                    | duration_seconds | num_samples | status | cluster_scope | hashed_username                                                  | job_id               | log_level | log_message                    
---------------------+-----------------+--------------------------------------------+------------------+-------------+--------+---------------+------------------------------------------------------------------+----------------------+-----------+--------------------------------
 2025-11-19 10:09:20 | arjangt-login-0 | 6.5.13-65-650-3434-22042-coreweave-amd64-3 |                0 |           0 |      0 | dm1-control   | bb261073db8b64c7bee79b4c712c5d78a704eb330f10d08647c5703544aa9cf2 | dual_test_001        | INFO      | Dual logging verification test 
 2025-11-19 10:09:20 | arjangt-login-0 | 6.5.13-65-650-3434-22042-coreweave-amd64-3 |                0 |        5000 |      0 | dm1-control   | bb261073db8b64c7bee79b4c712c5d78a704eb330f10d08647c5703544aa9cf2 | integration_test_456 | INFO      | Structured logging test        
 2025-11-19 10:09:19 | arjangt-login-0 | 6.5.13-65-650-3434-22042-coreweave-amd64-3 |                0 |           0 |      0 | dm1-control   | bb261073db8b64c7bee79b4c712c5d78a704eb330f10d08647c5703544aa9cf2 | test_critical        | CRITICAL  | Critical message               
 2025-11-19 10:09:19 | arjangt-login-0 | 6.5.13-65-650-3434-22042-coreweave-amd64-3 |                0 |           0 |      0 | dm1-control   | bb261073db8b64c7bee79b4c712c5d78a704eb330f10d08647c5703544aa9cf2 | test_debug           | DEBUG     | Debug message                  
 2025-11-19 10:09:19 | arjangt-login-0 | 6.5.13-65-650-3434-22042-coreweave-amd64-3 |                0 |           0 |      0 | dm1-control   | bb261073db8b64c7bee79b4c712c5d78a704eb330f10d08647c5703544aa9cf2 | test_error           | ERROR     | Error message                  
 2025-11-19 10:09:19 | arjangt-login-0 | 6.5.13-65-650-3434-22042-coreweave-amd64-3 |                0 |           0 |      0 | dm1-control   | bb261073db8b64c7bee79b4c712c5d78a704eb330f10d08647c5703544aa9cf2 | test_info            | INFO      | Info message                   
 2025-11-19 10:09:19 | arjangt-login-0 | 6.5.13-65-650-3434-22042-coreweave-amd64-3 |                0 |           0 |      0 | dm1-control   | bb261073db8b64c7bee79b4c712c5d78a704eb330f10d08647c5703544aa9cf2 | test_warning         | WARNING   | Warning message                
 2025-11-19 10:09:19 | arjangt-login-0 | 6.5.13-65-650-3434-22042-coreweave-amd64-3 |                0 |           0 |      1 | dm1-control   | bb261073db8b64c7bee79b4c712c5d78a704eb330f10d08647c5703544aa9cf2 | test_job_123         | INFO      | Integration test message       
 2025-11-19 10:09:14 | arjangt-login-0 | 6.5.13-65-650-3434-22042-coreweave-amd64-3 |                0 |           0 |      0 | dm1-control   | bb261073db8b64c7bee79b4c712c5d78a704eb330f10d08647c5703544aa9cf2 | dual_test_001        | INFO      | Dual logging verification test 
 2025-11-19 10:09:14 | arjangt-login-0 | 6.5.13-65-650-3434-22042-coreweave-amd64-3 |                0 |        5000 |      0 | dm1-control   | bb261073db8b64c7bee79b4c712c5d78a704eb330f10d08647c5703544aa9cf2 | integration_test_456 | INFO      | Structured logging test

arjtala added 2 commits November 14, 2025 16:58

replacing standard logger with frogger

5abc2f0

replacing standard logger with frogger

684f62a

arjtala requested review from dongwang218, swdanielli and yangli5t as code owners November 14, 2025 23:36

meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Nov 14, 2025

arjtala added 7 commits November 17, 2025 18:27

sorting imports

77241e4

fixing mypy errors

c164265

fixing black formatting errors

3abad91

switching to ssh

7857ad4

switching to ssh

6d54e26

switching to ssh

aae2a0f

adding test

065566b

yangli5t reviewed Nov 19, 2025

View reviewed changes

arjtala added 6 commits November 18, 2025 20:27

adding test

f0b4624

fixing unit tests

7e4f58c

transmit function should pass the log_level as string

868eaf6

transmit function should pass the log_level as string

3d4e7b3

setting logging level config at begging of the test

46362f1

moving logger test to utils subfolder

091504b

isort

54d3c3c

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Frogger#113

Frogger#113
arjtala wants to merge 16 commits intomainfrom
frogger

arjtala commented Nov 14, 2025 •

edited

Loading

Uh oh!

yangli5t Nov 19, 2025

Uh oh!

arjtala commented Nov 19, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

arjtala commented Nov 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why ?

How ?

Test plan

Devserver:

Uh oh!

yangli5t Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

arjtala commented Nov 19, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

arjtala commented Nov 14, 2025 •

edited

Loading