Skip to content

Conversation

@fembina
Copy link
Contributor

@fembina fembina commented Mar 29, 2025

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request fixes issues in the Telegram Bridge's JSON serialization for a text-or-number value converter, ensuring that JSON write operations do not throw errors unexpectedly.

  • Use a Sequence for collecting key/value pairs before freezing into a dictionary
  • Update error messages and improve method signatures for better clarity
  • Refactor the TextOrNumberValue struct by renaming internal fields and updating annotations

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
Sources/Falko.Talkie.Bridges.Telegram/Serialization/TextOrNumberValueDictionaryConverter.cs Refactored JSON read/write operations; replaced Dictionary with Sequence; updated error messages and formatting
Sources/Falko.Talkie.Bridges.Telegram/Models/TextOrNumberValue.cs Renamed internal fields and updated annotations; changed ToString() to return a constant string
Comments suppressed due to low confidence (1)

Sources/Falko.Talkie.Bridges.Telegram/Serialization/TextOrNumberValueDictionaryConverter.cs:81

  • [nitpick] Consider revising this error message to clearly indicate the problem, for example: "Value for key '{pair.Key}' does not contain a valid number or text."
throw new JsonException($"Value for key '{pair.Key}' does not contain a number or text, or empty.");

…throw-json-error-on-json-write-operations

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@fembina fembina force-pushed the 70-in-telegram-bridge-text-or-number-value-dictionary-converter-can-throw-json-error-on-json-write-operations branch from dc27a34 to 61572cc Compare March 29, 2025 23:58
@fembina fembina merged commit 527e3bf into main Mar 30, 2025
1 check passed
@fembina fembina deleted the 70-in-telegram-bridge-text-or-number-value-dictionary-converter-can-throw-json-error-on-json-write-operations branch March 30, 2025 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

in telegram-bridge text-or-number-value dictionary converter can throw json-error on json-write operations

2 participants