Skip to content

refactor: Split up commands into RUN steps #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
emgrav wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor: Split up commands into RUN steps #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 24 additions & 24 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,28 +3,28 @@ FROM docker.io/rust:bullseye
ARG NIGHTLY_VERSION=nightly-2023-09-10
ENV NIGHTLY_VERSION=${NIGHTLY_VERSION}

RUN apt update -yqq \
&& apt install -yqq --no-install-recommends \
build-essential cmake libssl-dev pkg-config git musl-tools jq xmlstarlet lcov protobuf-compiler libprotobuf-dev libprotoc-dev \
&& rustup toolchain uninstall /usr/local/rustup/toolchains/* \
&& rustup toolchain add $NIGHTLY_VERSION --component rustfmt --component clippy --component llvm-tools-preview \
&& rustup toolchain add stable --component rustfmt --component clippy --component llvm-tools-preview \
&& rustup default stable \
&& cargo install grcov \
&& cargo install cargo-cache \
&& cargo install cargo-llvm-cov \
&& cargo install cargo-deny \
&& cargo install sqlx-cli \
&& cargo install --git https://github.com/paritytech/cachepot \
&& cargo install --git https://github.com/FlixCoder/cargo-lints.git \
&& cargo install typos-cli \
&& cargo install conventional_commits_linter \
&& cargo install cargo-udeps --locked \
&& cargo install cargo-nextest \
&& cargo install cargo-readme \
&& cargo install gitlab-report \
&& cargo install cargo-audit \
&& cargo install cargo-vet \
&& cargo install --git https://github.com/kate-shine/cargo-license.git --branch shine/gitlab_license_scan --force # fix after it gets merged to upstream \
&& cargo cache -a
RUN apt update -yqq
RUN apt install -yqq --no-install-recommends \
build-essential cmake libssl-dev pkg-config git musl-tools jq xmlstarlet lcov protobuf-compiler libprotobuf-dev libprotoc-dev
RUN rustup toolchain uninstall /usr/local/rustup/toolchains/*
RUN rustup toolchain add $NIGHTLY_VERSION --component rustfmt --component clippy --component llvm-tools-preview
Copy link
Contributor

@sirewix sirewix Jun 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should put nightly at the end as it is the only layer that would change frequently and the rest can be cached

RUN rustup toolchain add stable --component rustfmt --component clippy --component llvm-tools-preview
RUN rustup default stable
RUN cargo install grcov
RUN cargo install cargo-cache
RUN cargo install cargo-llvm-cov
RUN cargo install cargo-deny
RUN cargo install sqlx-cli
RUN cargo install --git https://github.com/paritytech/cachepot
RUN cargo install --git https://github.com/FlixCoder/cargo-lints.git
RUN cargo install typos-cli
RUN cargo install conventional_commits_linter
RUN cargo install cargo-udeps --locked
RUN cargo install cargo-nextest
RUN cargo install cargo-readme
RUN cargo install gitlab-report
RUN cargo install cargo-audit
RUN cargo install cargo-vet
RUN cargo install --git https://github.com/kate-shine/cargo-license.git --branch shine/gitlab_license_scan --force # fix after it gets merged to upstream
RUN cargo cache -a
COPY cobertura_transform.xslt /opt/