Fix empty field handling in multi-record file #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RFC 4180 section 2.4 allows one or more fields (i.e. not zero). Given a three-record CSV file with one field per record, it's reasonable for it to have a blank second line indicating that the second record's only field is empty. Presently, this library reads that line as having no fields. There is no need for it to, since the RFC doesn't allow records with no fields. This patch fixes the library so that it correctly reads that second line as having one empty field. This change is not backwards compatible. The earlier specification in test-happy-ending is for a file with nothing but three spaces to be read as having one record with no fields. I've changed that test specification to say that such a file will now be read in as having one record with one empty field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC 4180 section 2.4 allows one or more fields (i.e. not zero). Given a three-record CSV file with one field per record, it's reasonable for it to have a blank second line indicating that the second record's only field is empty. Presently, this library reads that line as having no fields. There is no need for it to, since the RFC doesn't allow records with no fields. This patch fixes the library so that it correctly reads that second line as having one empty field.
This change is not backwards compatible. The earlier specification in test-happy-ending is for a file with nothing but three spaces to be read as having one record with no fields. I've changed that test specification to say that such a file will now be read in as having one record with one empty field.