Skip to content

物理プロパティを論理プロパティに変換しRTLサポートを改善 #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vividtone wants to merge 1 commit into
base: master
Choose a base branch
from
Open

物理プロパティを論理プロパティに変換しRTLサポートを改善 #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 35 additions & 21 deletions stylesheets/application.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,10 @@ h1, h2, h3, h4 {
text-shadow: -1px -1px 1px rgba(0, 0, 0, 0.3);
}

[dir="rtl"] #header h1 {
text-shadow: 1px -1px 1px rgba(0, 0, 0, 0.3);
}

#content h1, h2, h3, h4 {
color: var(--oc-gray-9, #212529); /* Initial value is fallbak for Redmine < 7.0 */
}
Expand All @@ -33,6 +37,10 @@ h1, h2, h3, h4 {
box-shadow: 3px -2px 2px rgba(0, 0, 0, 0.1);
}

[dir="rtl"] #main-menu li :is(a.selected, a.selected:hover) {
box-shadow: -3px -2px 2px rgba(0, 0, 0, 0.1);
}


/***** Links *****/

Expand All @@ -47,17 +55,18 @@ a#toggle-completed-versions {
/***** Tables *****/

table.list th {
padding: 4px 2px
padding-block: 4px;
padding-inline: 2px;
}

tr.changeset td.author {
text-align: center;
width: 15%;
inline-size: 15%;
}

tr.changeset td.committed_on {
text-align: center;
width: 15%;
inline-size: 15%;
}

/* assinged to me, created by me */
Expand All @@ -72,7 +81,7 @@ table.list.issues tr.closed td {

td.parent {
white-space: normal;
text-align: left;
text-align: start;
}

/* overdue */
Expand Down Expand Up @@ -197,7 +206,8 @@ tr.priority-lowest a {

.issue .contextual {
margin: 0;
padding: 2px 3px;
padding-block: 2px;
padding-inline: 3px;
border-radius: 3px;
background: rgba(var(--oc-white-rgb, 255, 255, 255), 0.8);
border: 1px solid var(--oc-gray-4, #ced4da);
Expand Down Expand Up @@ -225,12 +235,11 @@ div#activity dd span.description, #search-results dd span.description {
}

form .attributes {
margin-bottom: 8px
margin-block-end: 8px
Copy link

Copilot AI Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing semicolon at end of CSS declaration.

Copilot uses AI. Check for mistakes.
}

form .attributes p {
padding-top: 1px;
padding-bottom: 2px;
padding-block: 1px 2px;
}

div.wiki-page .contextual a {
Expand All @@ -257,7 +266,7 @@ div.wiki p {
}

div.wiki li {
margin-bottom: 4px;
margin-block-end: 4px;
}

/***** My page layout *****/
Expand All @@ -275,7 +284,10 @@ div.wiki li {
}

div.attributes[id="attributes"] {
border: 1px 0 0 0 0 solid #f00;
border-block-width: 1px 0;
border-inline-width: 0;
border-style: solid;
border-color: #f00;
}

Comment on lines +287 to 292
Copy link

Copilot AI Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original border shorthand 1px 0 0 0 0 solid #f00 appears to have an extra value. The logical property conversion should match the intent of the original, which seems malformed. Verify the intended border values - the shorthand should only have 4 directional values, not 5.

Suggested change
border-block-width: 1px 0;
border-inline-width: 0;
border-style: solid;
border-color: #f00;
}
border-block-start: 1px solid #f00;
border-block-end: 0;
border-inline: 0;
}

Copilot uses AI. Check for mistakes.
Copy link
Collaborator

@ishikawa999 ishikawa999 Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vividtone
今まではborderに対する値の数が不正で実際には適用されていなかったCSSが、記法が修正されたことで機能するようになっています。

Image このスタイルの影響で赤い線が表示されるようになっているのですが、恐らく赤い線はレイアウトとしても不自然で、不要だと思います。 
div.attributes[id="attributes"] {
  border-block-width: 1px 0;
  border-inline-width: 0;
  border-style: solid;
  border-color: #f00;
}

の部分ごと消しても良いと思うのですが、どうでしょうか？

/***** calendar *****/
Expand All @@ -293,10 +305,12 @@ ul.cal div.assigned-to-me a {

/* 作成日・更新日に実際の日時を表示 */
a[href*="activity"][data-absolute-date*=":"] {
margin: 0 3px;
margin-block: 0;
margin-inline: 3px;
box-shadow: inset 0 -1.5em 0 rgba(0, 0, 0, 0.08);
display: inline-block;
padding: 0 3px;
padding-block: 0;
padding-inline: 3px;
border-radius: 3px;
}
a[href*="activity"][data-absolute-date*=":"]:before {
Expand All @@ -312,9 +326,8 @@ div.journal-content ul.journal-details {
color: var(--oc-gray-7, #495057);
background: var(--oc-gray-0, #f8f9fa);
border-radius: 3px;
padding-top: 3px;
padding-bottom: 3px;
margin-top: 10px;
padding-block: 3px;
margin-block-start: 10px;
}

div.journal-content ul.journal-details i:before {
Expand All @@ -329,23 +342,24 @@ div.journal-content ul.journal-details i:after {

/* news */
body.controller-news.action-index h3 {
margin-bottom: 4px;
margin-block-end: 4px;
}

body.controller-news.action-index .author {
margin-top: 0;
border-bottom: 1px dotted var(--oc-gray-4, #ced4da);
margin-block-start: 0;
border-block-end: 1px dotted var(--oc-gray-4, #ced4da);
}

body.controller-news.action-index .wiki {
margin: 12px 0 20px 30px;
margin-block: 12px 20px;
margin-inline: 30px 0;
}

/* アイコン間のマージンを調整して識別しやすく */
.contextual .icon, .buttons .icon {
margin-left: 5px;
margin-inline-start: 5px;
}

.contextual .icon:first-child, .buttons .icon:first-child {
margin-left: 0;
margin-inline-start: 0;
}