Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for additional PostgreSQL data types to the query builder library. The changes extend the column type system with new types for character data, binary data, numeric types, serial types, range types, and arrays.
Changes:
- Added new column type variants and builder methods for char, varchar, bytea, numeric, serial types (smallserial, serial, bigserial), range types (int4range, int8range, numrange, tsrange, tstzrange, daterange), and array support
- Added a panic check in the
default()method to prevent setting default values on generated columns - Added new test file for Iden escaping and qualified name rendering
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| pqb/src/table/column.rs | Adds new column type builder methods, enum variants, and SQL rendering logic for additional PostgreSQL data types; includes mutual exclusion check for default and generated columns |
| pqb/tests/types.rs | New test file for Iden identifier escaping detection and qualified table name rendering (unrelated to column types) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.