Merged
Conversation
simone-sanfratello
force-pushed
the
chore/maintenance
branch
from
5f55682 to
ec20f05
Compare
simone-sanfratello
force-pushed
the
chore/maintenance
branch
from
ec20f05 to
8834a65
Compare
Uzlopak
requested changes
Nov 20, 2025
Contributor
Uzlopak
left a comment
Uzlopak
left a comment
There was a problem hiding this comment.
why not directly use fetch? I would prefer removing that helper fn
kibertoad
approved these changes
Nov 20, 2025
Member
|
@Uzlopak wouldn't that require more boilerplate in every test? |
Contributor
|
@kibertoad Actually not. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gotin tests in favor of native fetch@jsumners/line-reporteras in case of failures it's not possible to see output