Make gen_finn_dt_tensor consider the numpy type for INT and FIXED types #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
jmitrevs
approved these changes
Jan 29, 2026
Collaborator
|
Why weren't tests run? The change looks fine, but I want to make sure the tests pass. |
Collaborator
Author
Hm, I don't know... I will try to rebase this on top of main and force-push to trigger the tests. |
iksnagreb
force-pushed
the
fix/gen_finn_dt_tensor
branch
from
45cfa03 to
99dd4dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the FINN datatype is, for example,
UINT64,np.random.randintstill implicitly defaults tonp.int64, making thehigh=finn_dt.max() + 1exceed the valid range:ValueError: high is out of bounds for int64. This happened to me in thestep_make_pynq_driverof a FINN build of aGather/Lookupnode where the index input has been annotated toUINT64.I think, the most generic solution to this is specifying the numpy datatype corresponding to the FINN datatype as an additional
dtype=argument to the function call. I am not sure whether it makes sense to add this to all the other cases as well, i.e., to BINARY, BIPOLAR and FLOAT32.