Add type hints to base classes to fix Pythons automatic type hinting for FINN/FINN+ #226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iksnagreb
approved these changes
Feb 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add type hints to a range of basic qonnx classes so that Pythons automatic type hinting works for the majority of FINN/FINN+ code.
Additionally, this fixes some edge cases for FLOAT32/FLOAT16, where the
allowedmethod of aDataTypereturns a bool instead of a numpy array of bools, which can cause crashes in some cases if an array is expected as an output type like for all other datatypes.For this reason I also augmented the datatype tests to test for this case.