Setup: remove max version of ONNX #235
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Note that #220 mentions why an upper limit was used in the past. Are there still such issues? Personally I have always been worried about upper limits. |
Contributor
|
Related issue: Xilinx/brevitas#1450 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix #234
The most recent versions of ONNX are needed for compatibility with torch 1.13, so this PR removes the maximum version requirementCurrent status is as follow:
Combining all these requirements, it means that we need two different versions of ONNX, whether we are using python 3.11 or not.
Above python 3.11, we can install latest version of everything.
Below python 3.11, we need a slightly older version of ONNX (1.17) to maintain compatibility with a slightly older version of onnxruntime (1.23.2)