fix: apply clippy suggestions across workspace#4414
Open
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Open
fix: apply clippy suggestions across workspace#4414devin-ai-integration[bot] wants to merge 1 commit intomainfrom
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Conversation
- Remove unused import (tauri::Manager) in desktop app - Remove unnecessary .to_string() call in posthog analytics - Add missing Safety doc to unsafe extern C functions in notification-macos - Use let chains instead of nested if-let in tiptap, fs-db migrations, and listener - Remove unnecessary explicit lifetime in group_by_session_id functions - Add plugins/cli2 to workspace exclude (no Cargo.toml present) Co-Authored-By: bot_apk <apk@cognition.ai>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
✅ Deploy Preview for hyprnote-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for hyprnote ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: apply clippy suggestions across workspace
Summary
Ran
cargo clippy --fixand manually applied remaining suggestions. Changes across 9 files:tauri::Managerinapps/desktop/src-tauri/src/lib.rs.to_string(): removed on already-&strvalue incrates/analytics/src/posthog.rs# Safetydoc: added to macro-generatedunsafe extern "C" fnincrates/notification-macos/src/lib.rsif letstatements into more concise let-chains (Rust 1.87+ stabilized feature) in:crates/tiptap/src/from_ast.rsplugins/fs-db/src/migrations/v1_0_2_nightly_14_extract_from_sqlite.rsplugins/fs-db/src/migrations/v1_0_2_nightly_1_from_v0.rsplugins/fs-db/src/version/macro.rs(4 levels → 1 chain)plugins/listener/src/actors/recorder.rsgroup_by_session_idsignatures (lifetime elision handles them)plugins/cli2to workspace exclude list (Cargo.toml) since the directory exists but has noCargo.toml(was removed in earlier commits)Review & Testing Checklist for Human
plugins/fs-db/src/version/macro.rswhere 4 levels collapsed into 1) should be functionally equivalent to the original nestedif letstatements. The indentation style is unusual but generated by clippy.version/macro.rshad complex nesting changes, verify version parsing still works correctly with various inputs (especially prerelease tags).plugins/cli2exclusion should allowcargo checkto succeed without errors about missingCargo.toml.Notes
tauri-nspanel,notch,tcc, etc. were excluded)cargo fmtif the indentation looks offSession: https://app.devin.ai/sessions/7a48bda866184366b928213355295c92
Requested by: bot_apk