fix: apply clippy suggestions across workspace#4415
Open
devin-ai-integration[bot] wants to merge 2 commits intomainfrom
Open
fix: apply clippy suggestions across workspace#4415devin-ai-integration[bot] wants to merge 2 commits intomainfrom
devin-ai-integration[bot] wants to merge 2 commits intomainfrom
Conversation
- Auto-fix: simplify iterator in owhisper-client batch adapter - Suppress dead_code warnings for pub(crate) items in audio crate (async_ring, rt_ring) - Suppress too_many_arguments warnings in transcribe-proxy relay (builder, handler) Co-Authored-By: bot_apk <apk@cognition.ai>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
✅ Deploy Preview for hyprnote-storybook canceled.
|
✅ Deploy Preview for hyprnote canceled.
|
Co-Authored-By: bot_apk <apk@cognition.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: apply clippy suggestions across workspace
Summary
Ran
cargo clippy --fixand manually addressed remaining warnings for all crates compilable on Linux.Auto-fixed (1 change):
crates/owhisper-client/src/adapter/cactus/batch.rs: Collapsed nestedif let+ifinto a let-chain (clippycollapsible_if), then corrected indentation to satisfydprintformattingManually suppressed (4 files):
crates/audio/src/async_ring.rs,crates/audio/src/rt_ring.rs: Added#[allow(dead_code)]on 4 unusedpub(crate)items (did_pop_chunk,has_buffered_samples,convert_and_push_to_ringbuf,push_f32_to_ringbuf)crates/transcribe-proxy/src/relay/builder.rs,handler.rs: Added#[allow(clippy::too_many_arguments)]on 4 functions with 8 paramsNote: macOS-only crates (
am2,tcc,notch,control-tauri, etc.) andcactus/tools(ARM build issues on x86) could not be checked on this Linux environment.CI status:
fmtandcichecks pass.batchanddesktop_ci (linux-x86_64)fail due to pre-existingcactus-sysARM cross-compilation issue (unrelated to this PR).Review & Testing Checklist for Human
batch.rs(lines 305-312) is semantically equivalent to the original nestedif let/if— this is the only logic change#[allow(dead_code)]items inaudiocrate are intentionally kept (e.g., for future use or platform-specific builds) rather than candidates for removaltoo_many_argumentssuppressions intranscribe-proxyare acceptable vs. warranting a config-struct refactorcargo clippyon macOS to catch warnings in the excluded platform-specific cratesNotes