Skip to content

show onboarding correctly to new tab based format in devtool #4423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ComputelessComputer wants to merge 1 commit into
base: main
Choose a base branch
from
Open

show onboarding correctly to new tab based format in devtool #4423

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 14 additions & 8 deletions apps/desktop/src/sidebar/devtool.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,13 +54,19 @@ function DevtoolCard({
function NavigationCard() {
const openNew = useTabs((s) => s.openNew);

const handleShowMain = useCallback(() => {
void windowsCommands.windowShow({ type: "main" });
const showMainWindow = useCallback(async () => {
await windowsCommands.windowShow({ type: "main" });
}, []);

const handleShowOnboarding = useCallback(() => {
const handleShowEmptyTab = useCallback(async () => {
await showMainWindow();
openNew({ type: "empty" });
}, [openNew, showMainWindow]);

const handleShowOnboarding = useCallback(async () => {
await showMainWindow();
openNew({ type: "onboarding" });
}, [openNew]);
}, [openNew, showMainWindow]);

const handleShowControl = useCallback(() => {
void windowsCommands.windowShow({ type: "control" });
Expand All @@ -81,7 +87,7 @@ function NavigationCard() {
<div className="flex flex-col gap-1.5">
<button
type="button"
onClick={handleShowOnboarding}
onClick={() => void handleShowOnboarding()}
className={cn([
"w-full rounded-md px-2.5 py-1.5",
"text-left text-xs font-medium",
Expand All @@ -90,11 +96,11 @@ function NavigationCard() {
"hover:border-neutral-300 hover:bg-neutral-50",
])}
>
Onboarding
Onboarding Tab
</button>
<button
type="button"
onClick={handleShowMain}
onClick={() => void handleShowEmptyTab()}
className={cn([
"w-full rounded-md px-2.5 py-1.5",
"text-left text-xs font-medium",
Expand All @@ -103,7 +109,7 @@ function NavigationCard() {
"hover:border-neutral-300 hover:bg-neutral-50",
])}
>
Main
Empty Tab
</button>
<button
type="button"
Expand Down
Loading