Open
Conversation
Implicitly done by upgrading to CentOS 8. Removed db4-utils and db4 that weren't available in CentOS 7 but now error in CentOS 8.
rafzei
reviewed
May 20, 2021
| Usage="docker run -d -p [HOST PORT NUMBER]:21 -v [HOST FTP HOME]:/home/vsftpd fauria/vsftpd" \ | ||
| Version="1.0" | ||
|
|
||
| RUN yum -y update && yum clean all |
There was a problem hiding this comment.
I think it is not needed to update repositories. The image will be ~100MB lighter
Author
There was a problem hiding this comment.
Probably best to have the latest updates, but that's not really the focus of this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implicitly done by upgrading to CentOS 8.
Removed db4-utils and db4 that weren't available in CentOS 7 but now error in CentOS 8.