fixes for target image size same as the source image #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. docstring that explains the arguments. 2. mask fixing if mask is not uint8. or 3 dim. 3. np.bool deprecated. and removed in numpy. suggestion is to use bool. updated with that. 4. when target_img is of same size as the source img, there was index overflow in diagonal that happens sometimes. created a bound check for the diagonal update. atleast the current api would work for the same size. for the target image less than source image, user needs to take care, as reizing could produce skew.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
atleast the current api would work for the same size. for the target image less than source image, user needs to take care, as reizing could produce skew.