Adding a repo for (another) Angular/Feather implementation, with a newer, Angular 20 approach#1276
Open
adeeena wants to merge 1 commit intofeathericons:mainfrom
Open
Adding a repo for (another) Angular/Feather implementation, with a newer, Angular 20 approach#1276adeeena wants to merge 1 commit intofeathericons:mainfrom
adeeena wants to merge 1 commit intofeathericons:mainfrom
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found that the previous implementation of https://github.com/michaelbazos/angular-feather , despite its correctness, got deprecated by the fact that it targeted Angular 12, and since then a lot of linguistic and structural changes have been made.
Also, I wanted to preserve the initially imagined
<i data-feather=...format instead of having one component definition per icon; resulting a more future-proof approach.