Added ref prop to IconProps interface#79
Open
filingroove wants to merge 2 commits intofeathericons:masterfrom
Open
Added ref prop to IconProps interface#79filingroove wants to merge 2 commits intofeathericons:masterfrom
ref prop to IconProps interface#79filingroove wants to merge 2 commits intofeathericons:masterfrom
Conversation
filingroove
changed the title
ref prop to IconProps interface
|
@carmelopullara apologies for the spam, just wanted to draw your attention. |
|
@carmelopullara not urgent, but any chance we could merge this one? We're also experiencing a TS error here |
|
Following this |
|
With React19, it looks like I also found type issue while testing out react19 and have reported the issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #78