g597.kirilenko.task4 #327
Open
g597.kirilenko.task4 #327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ignorer
reviewed
Dec 21, 2016
Collaborator
ignorer
left a comment
ignorer
left a comment
There was a problem hiding this comment.
Нет авторизации, не используется БД
| public class BillingDatabaseConfiguration { | ||
| @Bean | ||
| public DataSource billingDataSource( | ||
| @Value("${ru.mipt.java2016.homework.g597.kirilenko.task4.jdbcUrl}") String jdbcUrl, |
Collaborator
There was a problem hiding this comment.
Вот такое стоит либо вынести в конфиг, либо прописать здесь же как значение по умолчанию. Иначе, как это случилось и у меня, другие не смогут запустить, пока не подадут правильную опцию jvm.
homework-g597-kirilenko/pom.xml
Outdated
| <version>1.0.0</version> | ||
| <scope>test</scope> | ||
| </dependency> | ||
| <dependency> |
Collaborator
There was a problem hiding this comment.
Эту зависимость можно было бы выпилить, в целом.
| .logout().disable() | ||
| .csrf().disable() | ||
| .authorizeRequests() | ||
| .antMatchers("/eval/**").authenticated() |
Collaborator
There was a problem hiding this comment.
По-хорошему бы на все категории запросов из задания требовать аутентификацию. То есть function и variable тоже.
| @RequestMapping(path = "/variable/{variableName}", method = RequestMethod.PUT, | ||
| consumes = "text/plain", produces = "text/plain") | ||
| public void putVariable(@PathVariable String variableName, | ||
| @RequestBody String expr) throws ParsingException { |
Collaborator
There was a problem hiding this comment.
Беспощадное форматирование
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.