Fixes incorrect overlay box keys usage#39
Merged
feduke-nukem merged 5 commits intomainfrom Aug 7, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes bugs related to incorrect dialog overlay key usage, concurrent modification issues, and improves error handling for dialogs that aren't shown. The changes replace custom insertion/removal classes with default implementations and use dialog IDs as keys instead of class types.
Key changes:
- Replaced position-based and dialog type-based keys with dialog ID-based keys for overlay box entries
- Consolidated custom insertion/removal classes into default implementations that use dialog IDs
- Made hiding non-shown dialogs return normally instead of throwing assertion errors
Reviewed Changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| lib/src/core/easy_dialogs_controller.dart | Updates hide dialog logic to handle missing dialogs gracefully and fixes concurrent modification by creating a copy of entries |
| lib/src/core/easy_overlay.dart | Adds default insertion/removal classes and removes generic type parameters from mutation interfaces |
| lib/src/positioned/dialog/positioned_dialog.dart | Removes custom insertion/removal classes, uses default implementations with position as ID |
| lib/src/full_screen/dialog/full_screen_dialog.dart | Removes custom insertion/removal classes, uses default implementations with dialog ID |
| lib/src/core/widget/overlay_provider.dart | Updates method signatures to remove generic type constraints |
| test files | Updates test cases to use new default insertion/removal classes and corrected key references |
| pubspec.yaml | Version bump to 4.0.4 |
| CHANGELOG.md | Documents the bug fixes |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…/feduke-nukem/flutter_easy_dialogs into issue/incorrect-overlay-box-keys
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #39 +/- ##
==========================================
- Coverage 96.66% 94.49% -2.18%
==========================================
Files 18 18
Lines 750 726 -24
==========================================
- Hits 725 686 -39
- Misses 25 40 +15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
READY
Breaking Changes
NO
Description
closes #37
closes #38