Skip to content

docs: CI pipeline documentation#51

Merged
ar-neto merged 1 commit intomain-fairgbmfrom
docs/ci-documentation
Dec 9, 2025
Merged

docs: CI pipeline documentation#51
ar-neto merged 1 commit intomain-fairgbmfrom
docs/ci-documentation

Conversation

@ar-neto
Copy link
Collaborator

@ar-neto ar-neto commented Nov 14, 2025

The description of the CI scripts and workflows was documented via mermaid charts and markdown

Copy link
Collaborator

@reluzita reluzita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From someone who has no context on this repo, it would be nice to have some more context on the beginning of both docs. I'm being picky here, but there are some inconsistencies in the punctuation throughout the docs. I would say that simply putting these through chatgpt or something to make it more consistent and have some more text explaining the context would be a simple way to make it more readable!

The documentaion below showcases each CI scripts' functionality.

## append_comment.sh
This script allows for the
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sentence is incomplete, maybe something got lost here?

- task: cuda
- conda_env: test-env

The steps are presented below
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The steps are presented below
The steps are presented below:

- conda_env: test-env

The steps are presented below
### Setup or update software on host machine
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Setup or update software on host machine
### 1. Setup or update software on host machine

### Setup or update software on host machine
This step aims to setup the host machine with the necessary images and packages (Ubuntu image, Nvidia docker engine resources and docker)

### Setup and run tests
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Setup and run tests
### 2. Setup and run tests

- PYTHON_VERSION: 3.9
- TASK: 'check-links'

The steps are disclosed below.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The steps are disclosed below.
The steps are disclosed below:


The steps are disclosed below.

### Checkout repository
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Checkout repository
### 1. Checkout repository

### Checkout repository
This step checks out the relevant repo's last 5 commits without any submodules

### Setup and run tests
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Setup and run tests
### 2. Setup and run tests

- CONDA_ENV: test-env
- GITHUB_ACTIONS: 'true'

This workflow's steps are the following:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as before, you get the idea 😅

Copy link
Collaborator

@sgpjesus sgpjesus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is looking good, but it would benefit from a bit more of commentary (as Inês said). Additionally, if you can, please add which scripts can be safely removed from the .github folder.

@ar-neto ar-neto force-pushed the docs/ci-documentation branch from bd3ded9 to 18368c8 Compare November 27, 2025 18:06
@ar-neto ar-neto merged commit f67b2bb into main-fairgbm Dec 9, 2025
1 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants