Merged
Conversation
AndreFCruz
changed the title
Contributor
Author
|
Note: this CI build fail is related to the FairGBM repo not being public as of yet; I'll have to change the |
AndreFCruz
commented
May 26, 2022
...htgbm-provider/src/main/java/com/feedzai/openml/provider/lightgbm/FairGBMDescriptorUtil.java
Show resolved
Hide resolved
AndreFCruz
force-pushed
the
fairgbm-api-implementation
branch
4 times, most recently
from
c9d6487 to
23ca156
Compare
AndreFCruz
force-pushed
the
fairgbm-api-implementation
branch
from
23ca156 to
8b5d405
Compare
AlbertoEAF
reviewed
Jun 3, 2022
...lightgbm-provider/src/main/java/com/feedzai/openml/provider/lightgbm/LightGBMAlgorithms.java
Outdated
Show resolved
Hide resolved
AlbertoEAF
reviewed
Jun 3, 2022
...tgbm/lightgbm-provider/src/main/java/com/feedzai/openml/provider/lightgbm/SWIGTrainData.java
Outdated
Show resolved
Hide resolved
AlbertoEAF
reviewed
Jun 3, 2022
...tgbm/lightgbm-provider/src/main/java/com/feedzai/openml/provider/lightgbm/SWIGTrainData.java
Outdated
Show resolved
Hide resolved
AlbertoEAF
reviewed
Jun 3, 2022
...gbm/lightgbm-provider/src/test/java/com/feedzai/openml/provider/lightgbm/TestParameters.java
Show resolved
Hide resolved
AndreFCruz
commented
Jun 3, 2022
| .add(new FieldSchema("is_fraud_label", 7, | ||
| new CategoricalValueSchema(true, ImmutableSet.of("FALSE", "TRUE")))) | ||
| .add(new FieldSchema("is_fraud_label", 8, | ||
| new CategoricalValueSchema(true, ImmutableSet.of("False", "True")))) |
Contributor
Author
There was a problem hiding this comment.
yes, I added a new "sensitive_attribute" column using a few lines of Python and the True/False values changed after saving the new dataframe 😅
AlbertoEAF
reviewed
Jun 3, 2022
...ghtgbm/lightgbm-provider/src/test/java/com/feedzai/openml/provider/lightgbm/TestSchemas.java
Show resolved
Hide resolved
AlbertoEAF
reviewed
Jun 3, 2022
...tgbm/lightgbm-provider/src/main/java/com/feedzai/openml/provider/lightgbm/SWIGTrainData.java
Outdated
Show resolved
Hide resolved
AlbertoEAF
reviewed
Jun 3, 2022
...tgbm/lightgbm-provider/src/main/java/com/feedzai/openml/provider/lightgbm/SWIGTrainData.java
Outdated
Show resolved
Hide resolved
gandola
reviewed
Jun 7, 2022
...tgbm/lightgbm-provider/src/main/java/com/feedzai/openml/provider/lightgbm/SWIGTrainData.java
Outdated
Show resolved
Hide resolved
...t/java/com/feedzai/openml/provider/lightgbm/FairGBMBinaryClassificationModelTrainerTest.java
Outdated
Show resolved
Hide resolved
...gbm/lightgbm-provider/src/test/java/com/feedzai/openml/provider/lightgbm/TestParameters.java
Outdated
Show resolved
Hide resolved
...tgbm/lightgbm-provider/src/main/java/com/feedzai/openml/provider/lightgbm/SWIGTrainData.java
Show resolved
Hide resolved
added 12 commits
June 29, 2022 12:58
…bility with cpp code
Codecov Report
@@ Coverage Diff @@
## master #116 +/- ##
============================================
+ Coverage 79.90% 80.21% +0.30%
- Complexity 428 465 +37
============================================
Files 43 47 +4
Lines 1498 1607 +109
Branches 138 157 +19
============================================
+ Hits 1197 1289 +92
- Misses 224 231 +7
- Partials 77 87 +10
Continue to review full report at Codecov.
|
AlbertoEAF
reviewed
Jul 11, 2022
...-provider/src/test/java/com/feedzai/openml/provider/lightgbm/FairGBMParamParserUtilTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: ipiresmac <93192669+ipiresmac@users.noreply.github.com>
AlbertoEAF
reviewed
Jul 12, 2022
.../lightgbm-provider/src/test/java/com/feedzai/openml/provider/lightgbm/FairProvidersTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: ipiresmac <93192669+ipiresmac@users.noreply.github.com>
Co-authored-by: ipiresmac <93192669+ipiresmac@users.noreply.github.com>
AlbertoEAF
reviewed
Jul 12, 2022
...htgbm-provider/src/main/java/com/feedzai/openml/provider/lightgbm/FairGBMDescriptorUtil.java
Outdated
Show resolved
Hide resolved
AlbertoEAF
reviewed
Jul 12, 2022
...main/java/com/feedzai/openml/provider/lightgbm/LightGBMBinaryClassificationModelTrainer.java
Outdated
Show resolved
Hide resolved
…edzai-openml-java into fairgbm-api-implementation
Contributor
Author
|
Are we ready to merge this? 🎉 |
AlbertoEAF
approved these changes
Jul 13, 2022
Contributor
AlbertoEAF
left a comment
AlbertoEAF
left a comment
There was a problem hiding this comment.
Yup, it's ready :) 🎉
I'd say let's just wait for @gandola 's ok but we're done, we can then squash it :)
|
LGTM! 🥇 Cheers |
ghost
merged commit
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of the Java openml API for the C++ FairGBM algorithm (to be open-sourced soon).
As FairGBM was built on top of LightGBM, I just hijacked the current LightGBM openml API implementation and added a new algorithm descriptor for the new FairGBM parameters.
Other considerations: