Add CSVUtils to read CSV data for tests#57
Open
AlbertoEAF wants to merge 1 commit intofeedzai:masterfrom
Open
Conversation
This util serves to extract CSV data into MockInstance / MockDataset objects: + Easy CSV parsing of data into OpenML API objects with arbitrary schema + Respects all of OpenML API's parameter conventions + Automatic encoding into target schema (even with categoricals)
| ++categoryIndex; | ||
| } | ||
|
|
||
| throw new RuntimeException("Invalid input value for categorical field!"); |
Contributor
There was a problem hiding this comment.
Issue found: Avoid throwing raw exception types.
Author
|
Hello, I'm using this code in several tests for an internal machine learning provider. I saw more times the need to take raw data and generate MockDatasets from it for tests and found myself using this code more than once. I can create test code for all of this in case you find it necessary, and also please tell me if you find any other issues you believe I should address, or overall comments for improvement. Thank you! :) |
Contributor
|
This PR is on hold until we find some time to tackle the missing unit tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This util serves to extract CSV data into MockInstance / MockDataset objects:
Easy CSV parsing of data into OpenML API objects with arbitrary schema
Respects all of OpenML API's parameter conventions
Automatic encoding into target schema (even with categoricals)