Added a regex validator for FreeTextFieldType#69
Open
AndreFCruz wants to merge 1 commit intofeedzai:masterfrom
Open
Added a regex validator for FreeTextFieldType#69AndreFCruz wants to merge 1 commit intofeedzai:masterfrom
AndreFCruz wants to merge 1 commit intofeedzai:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #69 +/- ##
============================================
+ Coverage 84.82% 84.96% +0.14%
- Complexity 281 285 +4
============================================
Files 38 38
Lines 738 745 +7
Branches 69 71 +2
============================================
+ Hits 626 633 +7
Misses 79 79
Partials 33 33
|
antssilva96
reviewed
May 24, 2022
...ml-api/src/main/java/com/feedzai/openml/provider/descriptor/fieldtype/FreeTextFieldType.java
Outdated
Show resolved
Hide resolved
antssilva96
reviewed
May 24, 2022
...ml-api/src/main/java/com/feedzai/openml/provider/descriptor/fieldtype/FreeTextFieldType.java
Outdated
Show resolved
Hide resolved
antssilva96
reviewed
May 24, 2022
...ml-api/src/main/java/com/feedzai/openml/provider/descriptor/fieldtype/FreeTextFieldType.java
Outdated
Show resolved
Hide resolved
antssilva96
reviewed
May 24, 2022
...ml-api/src/main/java/com/feedzai/openml/provider/descriptor/fieldtype/FreeTextFieldType.java
Outdated
Show resolved
Hide resolved
AndreFCruz
force-pushed
the
freetext-input-validation
branch
from
7bcfc9b to
725883e
Compare
AndreFCruz
force-pushed
the
freetext-input-validation
branch
from
725883e to
41f2dcb
Compare
Author
|
hey, can we merge this? 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added an optional regex argument to the constructor of
FreeTextFieldTypeto validate the input.Further discussion found in Issue #68
Closes #68