Skip to content

Conversation

@resilient-maximus
Copy link

No description provided.

@fengyuanyang
Copy link
Owner

Hi @irohitsatya
It seems this pr doesn't pass coverage check.

Rule violated for class com.ordestiny.tdd.algorithms.SortingAlgorithms: lines covered ratio is 0.90, but expected minimum is 0.95

Could you fix it

@resilient-maximus
Copy link
Author

resilient-maximus commented Oct 27, 2020 via email

@fengyuanyang
Copy link
Owner

Hi, I am not sure how to fix this issue. Could you guide me with this please? Regards, Rohit Satya

On Tue, 27 Oct, 2020, 6:41 pm Owen Yang, @.***> wrote: Hi @irohitsatya https://github.com/irohitsatya It seems this pr doesn't pass coverage check. Rule violated for class com.ordestiny.tdd.algorithms.SortingAlgorithms: lines covered ratio is 0.90, but expected minimum is 0.95 Could you fix it — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#120 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMRZCKXPF436LX2IYL4NVWLSM3BI5ANCNFSM4TAREYSQ .

You can execute gradle tasks below by orders

  1. test
  2. jacocoTestReport

and check index.html under customJacocoReportDir
to see which line is not coverd.

@fengyuanyang
Copy link
Owner

Hi @irohitsatya
Have you given it a try ?

@resilient-maximus
Copy link
Author

resilient-maximus commented Oct 30, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants