Prevent empty segments from being added for syllable breaks#59
Open
rdavidson1994 wants to merge 1 commit intofestvox:masterfrom
Open
Prevent empty segments from being added for syllable breaks#59rdavidson1994 wants to merge 1 commit intofestvox:masterfrom
rdavidson1994 wants to merge 1 commit intofestvox:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The -p argument to input phones is meant to allow using '-' to indicate syllable breaks. Right now, this always fails with this error message:
The problem is that tokentosegs unconditionally adds a new segment to the utterance for every token. In the case of '-', this segment never has its name set and is never added to the syllable structure, which breaks some assumptions later on. Moving the relation_append call past the check for '-' solves the problem.