Open
Conversation
eade31a ("Honor environment variables passed at ./configure") made speech_tools record build flags in user_flags.mak. This however make the build less reproducible by recording flags from the environment. Also, external applications using it do not actually need to get flags from that, they can just inherit them from their own environment. Actually, I'd even argue that this is preferrable over seeing speech_tools hardcode flags that applications using its build system will then have to use.
Collaborator
|
I'm hoping to get to this shortly... I'd like to test and get a couple other things in first and make sure we don't have conflicts, but this is a good thing to do! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
eade31a ("Honor environment variables passed at ./configure") made
speech_tools record build flags in user_flags.mak. This however make the
build less reproducible by recording flags from the environment. Also,
external applications using it do not actually need to get flags from
that, they can just inherit them from their own environment. Actually,
I'd even argue that this is preferrable over seeing speech_tools
hardcode flags that applications using its build system will then have
to use.