walloc: fix size type from int => size_t#48
Open
lumpidu wants to merge 1 commit intofestvox:masterfrom
Open
Conversation
size_t is used for most moderm implementations of malloc, calloc, etc. Using int leads to issues, if there are really large chunks of memory used such as e.g. for 3.2 GB: Building clunits/ldom index WALLOC: failed to malloc -1094967296 bytes Signed-off-by: Daniel Schnell <dschnell@grammatek.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The type
size_tis used for most moderm implementations ofmalloc,calloc,realloc, etc.Using just signed types like
intleads to issues on 32-bit systems, if there are really large chunks of memory used such as e.g. for a chunk of 3.2 GB in Festival:Also, the macros
walloc(),wcalloc()&wrealloc()usesizeof(), which itself returnssize_tand notint.Compiling speech-tools and Festival with these changes, at least compiles on my Mac just fine.